-
Notifications
You must be signed in to change notification settings - Fork 523
ci: forward BP_EXTERNAL_S3_URL through benchmark triggers #18955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 6 commits
1778dfe
92dc737
e481582
c6bf817
cdec4a5
9647c96
cdd3c0a
c29d3bf
8bb5c70
401b141
c74b940
0380110
eafa982
9813578
a800e85
7d825dc
2e50382
ea2a0a5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,10 @@ stages: | |
| - release | ||
|
|
||
| variables: | ||
| # Benchmark trigger jobs forward $BP_EXTERNAL_S3_URL to downstream pipelines so | ||
| # an external orchestrator can override the S3 destination of benchmark results. | ||
| # Defaulted to empty here so an unset value forwards as "" rather than a literal. | ||
| BP_EXTERNAL_S3_URL: "" | ||
| REPO_LANG: python # "python" is used everywhere rather than "py" | ||
| REPO_NOTIFICATION_CHANNEL: "#apm-python-release" | ||
| RELEASE_ALLOW_TEST_FAILURES: false | ||
|
|
@@ -186,6 +190,8 @@ microbenchmarks: | |
| PARENT_PIPELINE_ID: $CI_PIPELINE_ID | ||
| # Disable VPA for benchmarks | ||
| DD_DISABLE_VPA: true | ||
| # Forward the external S3 destination override to the benchmark child pipeline. | ||
| BP_EXTERNAL_S3_URL: $BP_EXTERNAL_S3_URL | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a normal benchmark pipeline does not provide Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👀
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Valid. Changed the mechanism with which vars are forwarded. |
||
|
|
||
| apm-sdk-benchmarks: | ||
| stage: benchmarks | ||
|
|
@@ -214,6 +220,8 @@ macrobenchmarks: | |
| PARENT_PIPELINE_ID: $CI_PIPELINE_ID | ||
| # Disable VPA for benchmarks | ||
| DD_DISABLE_VPA: true | ||
| # Forward the external S3 destination override to the benchmark child pipeline. | ||
| BP_EXTERNAL_S3_URL: $BP_EXTERNAL_S3_URL | ||
| allow_failure: false | ||
| rules: | ||
| # Always run on nightly schedule or API triggered pipelines | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.