Skip to content

ci: stop saving riot venvs from gitlab jobs as artifacts#18961

Open
brettlangdon wants to merge 3 commits into
mainfrom
brettlangdon/remove.venv.artifacts
Open

ci: stop saving riot venvs from gitlab jobs as artifacts#18961
brettlangdon wants to merge 3 commits into
mainfrom
brettlangdon/remove.venv.artifacts

Conversation

@brettlangdon

Copy link
Copy Markdown
Member

Description

Doubt anyone is using these, and some jobs like appsec/appsec_integrations_flask_testagent will spend 20+ minutes trying to upload the venv artifacts.

Testing

Risks

Additional Notes

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codeowners resolved as

.gitlab/templates/build-base-venvs.yml                                  @DataDog/python-guild @DataDog/apm-core-python
.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 9, 2026

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 4974 circular imports that already exist on the base branch and have not been changed by this PR.

Show existing cycles (showing 5 of 4974 shortest)
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.aiokafka -> ddtrace.internal.datastreams
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.kafka -> ddtrace.internal.datastreams
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.botocore -> ddtrace.internal.datastreams
ddtrace.internal.core -> ddtrace._trace.span -> ddtrace.internal.core
ddtrace.internal.datastreams -> ddtrace.internal.datastreams.kombu -> ddtrace.internal.datastreams

To see all cycles, download the cycles-base.json and cycles-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/cycles.py compare cycles-base.json cycles-pr.json

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This change is marked for backport to 4.11, but it conflicts with that branch.
Attempting to cherrypick this change to 4.11 yielded the following error:

Auto-merging scripts/gen_gitlab_config.py
CONFLICT (content): Merge conflict in scripts/gen_gitlab_config.py
Auto-merging tests/contrib/suitespec.yml
CONFLICT (content): Merge conflict in tests/contrib/suitespec.yml
error: could not apply be5b0f2b92... Merge dc17ae8acf36acd70803c20c2011133dd2bae2bd into 857c18ac56b6a449cf9686582917026341ee2d78

The command used to test backporting was

git fetch origin 4.11 && git checkout origin/4.11 && git checkout -b backport-18961-to-4.11 && git cherry-pick -x --mainline 1 be5b0f2b924cd512bf32c0bec22f73734dbf4717

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Jul 9, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 11 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64, 1]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]   View in Datadog   GitLab

View all 11 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 113 jobs - 85 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1af7e5a | Docs | Datadog PR Page | Give us feedback!

@brettlangdon brettlangdon added changelog/no-changelog A changelog entry is not required for this PR. and removed backport 4.10 backport 4.11 labels Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This change is marked for backport to 4.10, but it conflicts with that branch.
Attempting to cherrypick this change to 4.10 yielded the following error:

Auto-merging .gitlab/tests.yml
CONFLICT (content): Merge conflict in .gitlab/tests.yml
Auto-merging scripts/gen_gitlab_config.py
CONFLICT (content): Merge conflict in scripts/gen_gitlab_config.py
Auto-merging tests/contrib/suitespec.yml
CONFLICT (content): Merge conflict in tests/contrib/suitespec.yml
error: could not apply be5b0f2b92... Merge dc17ae8acf36acd70803c20c2011133dd2bae2bd into 857c18ac56b6a449cf9686582917026341ee2d78

The command used to test backporting was

git fetch origin 4.10 && git checkout origin/4.10 && git checkout -b backport-18961-to-4.10 && git cherry-pick -x --mainline 1 be5b0f2b924cd512bf32c0bec22f73734dbf4717

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc17ae8acf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .gitlab/tests.yml Outdated
@pr-commenter

pr-commenter Bot commented Jul 9, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-10 14:12:45

Comparing candidate commit 1af7e5a in PR branch brettlangdon/remove.venv.artifacts with baseline commit b649ac8 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 617 metrics, 10 unstable metrics.

scenario:iast_aspects-re_expand_aspect

  • 🟥 execution_time [+256.112µs; +300.334µs] or [+7.147%; +8.381%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+84.221µs; +94.144µs] or [+19.449%; +21.740%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+12.707µs; +18.825µs] or [+8.233%; +12.197%]

scenario:span-start

  • 🟥 execution_time [+1.254ms; +1.395ms] or [+8.134%; +9.051%]

@brettlangdon brettlangdon reopened this Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants