Skip to content

chore: add ddtrace-internal as dependency #18969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
emmettbutler wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: add ddtrace-internal as dependency #18969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e22afe9
add ddtrace-internal as dependency
emmettbutler Jul 9, 2026
65cf954
compile
emmettbutler Jul 9, 2026
534379a
regenerate requirements.csv
emmettbutler Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .riot/requirements/a2bd7d4.txt → .riot/requirements/10127d8.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,16 @@
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/a2bd7d4.in
# pip-compile --allow-unsafe --no-annotate .riot/requirements/10127d8.in
#
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
exceptiongroup==1.3.1
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand All @@ -31,7 +32,7 @@ pytest-xdist==3.8.0
python-json-logger==2.0.7
sortedcontainers==2.4.0
tomli==2.4.1
typing-extensions==4.15.0
typing-extensions==4.16.0
uwsgi==2.0.31
wrapt==1.17.3
zope-event==6.2
Expand Down
7 changes: 4 additions & 3 deletions .riot/requirements/15788e4.txt → .riot/requirements/101aed9.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/15788e4.in
# pip-compile --allow-unsafe --no-annotate .riot/requirements/101aed9.in
#
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand Down
7 changes: 4 additions & 3 deletions .riot/requirements/1ee1bcc.txt → .riot/requirements/12ebbf8.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,15 @@
# This file is autogenerated by pip-compile with Python 3.13
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/1ee1bcc.in
# pip-compile --allow-unsafe --no-annotate .riot/requirements/12ebbf8.in
#
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand Down
17 changes: 6 additions & 11 deletions .riot/requirements/1676ee4.txt → .riot/requirements/150dd71.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
#
# This file is autogenerated by pip-compile with Python 3.14
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/1676ee4.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --no-annotate --no-strip-extras --python /home/bits/.pyenv/versions/3.14.5/bin/python3.14 --output-file .riot/requirements/150dd71.txt .riot/requirements/150dd71.in
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand All @@ -28,11 +25,9 @@ pytest-mock==3.15.1
pytest-randomly==4.1.0
pytest-xdist==3.8.0
python-json-logger==2.0.7
setuptools==81.0.0
sortedcontainers==2.4.0
uwsgi==2.0.31
wrapt==2.2.2
zope-event==5.0
zope-interface==7.2

# The following packages are considered to be unsafe in a requirements file:
setuptools==81.0.0
17 changes: 6 additions & 11 deletions .riot/requirements/11bc0e4.txt → .riot/requirements/16925a0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/11bc0e4.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --no-annotate --no-strip-extras --python /home/bits/.pyenv/versions/3.14.5/bin/python3.14 --output-file .riot/requirements/16925a0.txt .riot/requirements/16925a0.in
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand All @@ -28,11 +25,9 @@ pytest-mock==3.15.1
pytest-randomly==4.1.0
pytest-xdist==3.8.0
python-json-logger==2.0.7
setuptools==81.0.0
sortedcontainers==2.4.0
uwsgi==2.0.31
wrapt==1.17.3
zope-event==5.0
zope-interface==7.2

# The following packages are considered to be unsafe in a requirements file:
setuptools==81.0.0
17 changes: 6 additions & 11 deletions .riot/requirements/145d3e4.txt → .riot/requirements/170c77e.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
#
# This file is autogenerated by pip-compile with Python 3.14
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/145d3e4.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --no-annotate --no-strip-extras --python /home/bits/.pyenv/versions/3.12.13/bin/python3.12 --output-file .riot/requirements/170c77e.txt .riot/requirements/170c77e.in
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand All @@ -28,11 +25,9 @@ pytest-mock==3.15.1
pytest-randomly==4.1.0
pytest-xdist==3.8.0
python-json-logger==2.0.7
setuptools==81.0.0
sortedcontainers==2.4.0
uwsgi==2.0.31
wrapt==1.17.3
zope-event==5.0
zope-interface==7.2

# The following packages are considered to be unsafe in a requirements file:
setuptools==81.0.0
15 changes: 5 additions & 10 deletions .riot/requirements/15a331e.txt → .riot/requirements/1bf66b1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
#
# This file is autogenerated by pip-compile with Python 3.9
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/15a331e.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --no-annotate --no-strip-extras --python /home/bits/.pyenv/versions/3.9.25/bin/python3.9 --output-file .riot/requirements/1bf66b1.txt .riot/requirements/1bf66b1.in
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.10.7
ddtrace-internal==0.0.0rc12
exceptiongroup==1.3.1
execnet==2.1.2
gevent==26.5.0
Expand All @@ -30,14 +27,12 @@ pytest-mock==3.15.1
pytest-randomly==4.0.1
pytest-xdist==3.8.0
python-json-logger==2.0.7
setuptools==81.0.0
sortedcontainers==2.4.0
tomli==2.4.1
typing-extensions==4.15.0
typing-extensions==4.16.0
uwsgi==2.0.31
wrapt==1.17.3
zipp==3.23.1
zope-event==6.0
zope-interface==8.0.1

# The following packages are considered to be unsafe in a requirements file:
setuptools==81.0.0
17 changes: 6 additions & 11 deletions .riot/requirements/4b16172.txt → .riot/requirements/4262023.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
#
# This file is autogenerated by pip-compile with Python 3.13
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/4b16172.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --no-annotate --no-strip-extras --python /home/bits/.pyenv/versions/3.13.13/bin/python3.13 --output-file .riot/requirements/4262023.txt .riot/requirements/4262023.in
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand All @@ -28,11 +25,9 @@ pytest-mock==3.15.1
pytest-randomly==4.1.0
pytest-xdist==3.8.0
python-json-logger==2.0.7
setuptools==81.0.0
sortedcontainers==2.4.0
uwsgi==2.0.31
wrapt==2.2.2
zope-event==5.0
zope-interface==7.2

# The following packages are considered to be unsafe in a requirements file:
setuptools==81.0.0
17 changes: 6 additions & 11 deletions .riot/requirements/10afbe8.txt → .riot/requirements/62596a3.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
#
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/10afbe8.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --no-annotate --no-strip-extras --python /home/bits/.pyenv/versions/3.11.15/bin/python3.11 --output-file .riot/requirements/62596a3.txt .riot/requirements/62596a3.in
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand All @@ -28,11 +25,9 @@ pytest-mock==3.15.1
pytest-randomly==4.1.0
pytest-xdist==3.8.0
python-json-logger==2.0.7
setuptools==81.0.0
sortedcontainers==2.4.0
uwsgi==2.0.31
wrapt==1.17.3
zope-event==6.2
zope-interface==8.5

# The following packages are considered to be unsafe in a requirements file:
setuptools==81.0.0
19 changes: 7 additions & 12 deletions .riot/requirements/c056455.txt → .riot/requirements/93909f6.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,13 @@
#
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/c056455.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --no-annotate --no-strip-extras --python /home/bits/.pyenv/versions/3.10.20/bin/python3.10 --output-file .riot/requirements/93909f6.txt .riot/requirements/93909f6.in
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
exceptiongroup==1.3.1
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand All @@ -29,13 +26,11 @@ pytest-mock==3.15.1
pytest-randomly==4.1.0
pytest-xdist==3.8.0
python-json-logger==2.0.7
setuptools==81.0.0
sortedcontainers==2.4.0
tomli==2.4.1
typing-extensions==4.15.0
typing-extensions==4.16.0
uwsgi==2.0.31
wrapt==2.2.2
zope-event==6.2
zope-interface==8.5

# The following packages are considered to be unsafe in a requirements file:
setuptools==81.0.0
15 changes: 5 additions & 10 deletions .riot/requirements/1b45a4d.txt → .riot/requirements/d7c7fdf.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
#
# This file is autogenerated by pip-compile with Python 3.9
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/1b45a4d.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --no-annotate --no-strip-extras --python /home/bits/.pyenv/versions/3.9.25/bin/python3.9 --output-file .riot/requirements/d7c7fdf.txt .riot/requirements/d7c7fdf.in
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.10.7
ddtrace-internal==0.0.0rc12
exceptiongroup==1.3.1
execnet==2.1.2
gevent==26.5.0
Expand All @@ -30,14 +27,12 @@ pytest-mock==3.15.1
pytest-randomly==4.0.1
pytest-xdist==3.8.0
python-json-logger==2.0.7
setuptools==81.0.0
sortedcontainers==2.4.0
tomli==2.4.1
typing-extensions==4.15.0
typing-extensions==4.16.0
uwsgi==2.0.31
wrapt==2.2.2
zipp==3.23.1
zope-event==6.0
zope-interface==8.0.1

# The following packages are considered to be unsafe in a requirements file:
setuptools==81.0.0
17 changes: 6 additions & 11 deletions .riot/requirements/a512f6c.txt → .riot/requirements/d815e3b.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
#
# This file is autogenerated by pip-compile with Python 3.12
# by the following command:
#
# pip-compile --allow-unsafe --no-annotate .riot/requirements/a512f6c.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --no-annotate --no-strip-extras --python /home/bits/.pyenv/versions/3.12.13/bin/python3.12 --output-file .riot/requirements/d815e3b.txt .riot/requirements/d815e3b.in
attrs==26.1.0
cloudpickle==3.1.2
coverage[toml]==7.14.3
coverage[toml]==7.15.0
ddtrace-internal==0.0.0rc12
execnet==2.1.2
gevent==26.5.0
greenlet==3.5.2
greenlet==3.5.3
httpretty==1.1.4
hypothesis==6.45.0
iniconfig==2.3.0
Expand All @@ -28,11 +25,9 @@ pytest-mock==3.15.1
pytest-randomly==4.1.0
pytest-xdist==3.8.0
python-json-logger==2.0.7
setuptools==81.0.0
sortedcontainers==2.4.0
uwsgi==2.0.31
wrapt==2.2.2
zope-event==5.0
zope-interface==7.2

# The following packages are considered to be unsafe in a requirements file:
setuptools==81.0.0
1 change: 1 addition & 0 deletions lib-injection/sources/requirements.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ bytecode,">=0.16.0,<1",python_version>='3.13.0'
bytecode,">=0.15.1,<1",python_version~='3.12.0'
bytecode,">=0.14.0,<1",python_version~='3.11.0'
bytecode,">=0.13.0,<1",python_version<'3.11'
ddtrace-internal,<1.0,
envier,~=0.6.1,
opentelemetry-api,">=1,<2",
wrapt,">=1,!=2.2.0,<3",
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop

@KowalskiThomas KowalskiThomas Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question about this: I remember hearing/reading that there was a maximum size we needed not to go over for serverless to be happy with ddtrace as a dependency. If we add ddtrace-internal as a dependency, are we not potentially making the layer with ddtrace in it bigger because of duplication (I'm mainly concerned about any native dependencies ddtrace-internal would have that "normal" ddtrace would also have).

(I don't have a solution, I just wanted to raise the question 😅)

Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ dependencies = [
"bytecode>=0.15.1,<1; python_version~='3.12.0'",
"bytecode>=0.14.0,<1; python_version~='3.11.0'",
"bytecode>=0.13.0,<1; python_version<'3.11'",
"ddtrace-internal<1.0",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add a lower bound for ddtrace-internal

This new runtime dependency only has an upper bound, but scripts/check-dependency-bounds rejects project dependencies without both lower and upper bounds and the generated “Check project dependencies” job runs that script for pyproject.toml changes. Please add the minimum ddtrace-internal version that contains the APIs ddtrace needs, for example alongside the existing <1.0 cap, so this dependency policy check does not fail and older prereleases cannot satisfy constrained installs.

Useful? React with 👍 / 👎.

Comment thread
emmettbutler marked this conversation as resolved.
"envier~=0.6.1",
"opentelemetry-api>=1,<2",
# TODO: lift the `!=2.2.0` exclusion once wrapt ships a release that
Expand Down
1 change: 1 addition & 0 deletions requirements.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ bytecode,">=0.16.0,<1",python_version>='3.13.0'
bytecode,">=0.15.1,<1",python_version~='3.12.0'
bytecode,">=0.14.0,<1",python_version~='3.11.0'
bytecode,">=0.13.0,<1",python_version<'3.11'
ddtrace-internal,<1.0,
envier,~=0.6.1,
opentelemetry-api,">=1,<2",
wrapt,">=1,!=2.2.0,<3",
Expand Down
Loading
Loading