Skip to content

refactor(profiling): split stack sampler helpers #18975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taegyunkim wants to merge 4 commits into
base: main
Choose a base branch
from
+22 −13
Open

refactor(profiling): split stack sampler helpers #18975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ac5dd7
refactor(profiling): extract render_unwound_stacks helper
taegyunkim Jul 9, 2026
9b2c70e
refactor(profiling): extract render_unwound_stacks helper
taegyunkim Jul 9, 2026
2f36ae8
Merge branch 'taegyunkim/prof-14213-stack-sampler-refactor' of https:…
taegyunkim Jul 10, 2026
584be28
Merge branch 'main' into taegyunkim/prof-14213-stack-sampler-refactor
taegyunkim Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ddtrace/internal/datadog/profiling/stack/echion/echion/threads.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ class ThreadInfo
};

private:
void render_unwound_stacks(EchionSampler&);
[[nodiscard]] Result<void> unwind_tasks(EchionSampler&, PyThreadState*);
void unwind_greenlets(EchionSampler&, PyThreadState*, unsigned long);
[[nodiscard]] Result<std::vector<TaskInfo::Ptr>> get_all_tasks(EchionSampler&, PyThreadState* tstate);
Expand Down
34 changes: 21 additions & 13 deletions ddtrace/internal/datadog/profiling/stack/src/echion/threads.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,21 +708,10 @@ ThreadInfo::unwind_greenlets(EchionSampler& echion, PyThreadState* tstate, unsig
}

// ----------------------------------------------------------------------------
Result<void>
ThreadInfo::sample(EchionSampler& echion, PyThreadState* tstate, microsecond_t delta)
void
ThreadInfo::render_unwound_stacks(EchionSampler& echion)
{
auto& renderer = echion.renderer();
renderer.render_thread_begin(tstate, name, delta, thread_id, native_id);

microsecond_t previous_cpu_time = cpu_time;
auto update_cpu_time_success = update_cpu_time();
if (!update_cpu_time_success) {
return ErrorKind::CpuTimeError;
}

renderer.render_cpu_time(cpu_time - previous_cpu_time);

this->unwind(echion, tstate);

// Render in this order of priority
// 1. asyncio Tasks stacks (if any)
Expand Down Expand Up @@ -755,6 +744,25 @@ ThreadInfo::sample(EchionSampler& echion, PyThreadState* tstate, microsecond_t d
python_stack.render(echion);
renderer.render_stack_end();
}
}

// ----------------------------------------------------------------------------
Result<void>
ThreadInfo::sample(EchionSampler& echion, PyThreadState* tstate, microsecond_t delta)
{
auto& renderer = echion.renderer();
renderer.render_thread_begin(tstate, name, delta, thread_id, native_id);

microsecond_t previous_cpu_time = cpu_time;
auto update_cpu_time_success = update_cpu_time();
if (!update_cpu_time_success) {
return ErrorKind::CpuTimeError;
}

renderer.render_cpu_time(cpu_time - previous_cpu_time);

this->unwind(echion, tstate);
this->render_unwound_stacks(echion);

return Result<void>::ok();
}
Expand Down
Loading