Skip to content

test(fastapi): skip flaky websocket subprocess test on 3.19 #18982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
christophe-papazian wants to merge 1 commit into
base: 3.19
Choose a base branch
from
+4 −0
Draft

test(fastapi): skip flaky websocket subprocess test on 3.19 #18982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/contrib/fastapi/test_fastapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,6 +624,7 @@ def _run_websocket_send_only_test():
fastapi_unpatch()


@pytest.mark.skip(reason="asyncio loop-teardown STDERR noise fails subprocess empty-stderr check on 3.19")
@pytest.mark.subprocess(
env=dict(
DD_TRACE_WEBSOCKET_MESSAGES_ENABLED="true",
Expand All @@ -636,6 +637,7 @@ def test_traced_websocket(test_spans, snapshot_app):
_run_websocket_test()


@pytest.mark.skip(reason="asyncio loop-teardown STDERR noise fails subprocess empty-stderr check on 3.19")
@pytest.mark.subprocess(
env=dict(
DD_TRACE_WEBSOCKET_MESSAGES_ENABLED="true",
Expand All @@ -648,6 +650,7 @@ def test_websocket_only_sends(test_spans, snapshot_app):
_run_websocket_send_only_test()


@pytest.mark.skip(reason="asyncio loop-teardown STDERR noise fails subprocess empty-stderr check on 3.19")
@pytest.mark.subprocess(
env=dict(
DD_TRACE_WEBSOCKET_MESSAGES_ENABLED="true",
Expand All @@ -661,6 +664,7 @@ def test_websocket_tracing_sampling_not_inherited(test_spans, snapshot_app):
_run_websocket_test()


@pytest.mark.skip(reason="asyncio loop-teardown STDERR noise fails subprocess empty-stderr check on 3.19")
@pytest.mark.subprocess(
env=dict(
DD_TRACE_WEBSOCKET_MESSAGES_ENABLED="true",
Expand Down
Loading