ci(build): use bash instead of zsh on tart macOS runners#18987
Open
alee1246 wants to merge 2 commits into
Open
ci(build): use bash instead of zsh on tart macOS runners#18987alee1246 wants to merge 2 commits into
alee1246 wants to merge 2 commits into
Conversation
Set TART_EXECUTOR_SHELL=/bin/bash so the tart-executor runs jobs with bash rather than the VM's default zsh, per https://github.com/cirruslabs/gitlab-tart-executor. This removes the need for the zsh-specific workarounds added when tart runners were introduced (setopt shwordsplit, disabling FF_SCRIPT_SECTIONS). Also renames the runner tag from macos:sonoma-tart to macos:tart. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Circular import analysis
|
Codeowners resolved as |
Contributor
🎉 All green!🧪 All tests passed 🔄 Datadog retried 8 tests - 8 passed on retry 🚧 6 tests that failed were ignored due to quarantine 🔄 Datadog auto-retried 1 job - 1 passed on retry 🔗 Commit SHA: 4b8e682 | Docs | Datadog PR Page | Give us feedback! |
Plain /bin/bash runs non-interactive/non-login under the executor's SSH exec channel and skips ~/.bash_profile, so Homebrew's PATH setup never gets sourced and brew is missing. Passing -l makes bash a login shell. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
BenchmarksBenchmark execution time: 2026-07-10 18:54:07 Comparing candidate commit 4b8e682 in PR branch Found 0 performance improvements and 5 performance regressions! Performance is the same for 614 metrics, 10 unstable metrics. scenario:iastaspects-stringio_noaspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectssplit-rsplit_aspect
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
|
KowalskiThomas
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #17501. It was requested in the past to use
bashoverzshin the jobs using that tart runners.Sets
TART_EXECUTOR_SHELL="/bin/bash -l"on the tart macOS jobs so the gitlab-tart-executor runs bash instead of the VM's default zsh.This removes the zsh-specific workarounds that were added when the tart runners were introduced:
setopt shwordsplitinbuild macos arm64'sbefore_scriptFF_SCRIPT_SECTIONS: "false"onbuild macos arm64andos tests macos(disabled because GitLab's collapsible script-section wrapper was incompatible with zsh)Also renames the runner tag from
macos:sonoma-tarttomacos:tart.Testing
build macos arm64andos tests macosrunning under bash onmacos:tartrunnersAdditional Notes
CI-only change, no user-facing impact — will add the
changelog/no-changeloglabel.🤖 Generated with Claude Code