feat(config): introduce the global DD_AGENTLESS_ENABLED flag - #19631
feat(config): introduce the global DD_AGENTLESS_ENABLED flag#19631bwoebi wants to merge 1 commit into
Conversation
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 5d13957 | Docs | Datadog PR Page | Give us feedback! |
BenchmarksBenchmark execution time: 2026-08-12 14:46:25 Comparing candidate commit 5d13957 in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 613 metrics, 10 unstable metrics. scenario:httppropagationinject-ids_only
scenario:iastaspects-lower_aspect
scenario:iastaspects-title_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:telemetryaddmetric-1-count-metric-1-times
scenario:tracer-small
|
acc71f6 to
519b315
Compare
Codeowners resolved asResolved from the full PR diff against |
Dependency direction analysis
|
Circular import analysis
|
519b315 to
0b92f6e
Compare
0b92f6e to
5d13957
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d139570b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ci_visibility = DDConfig.d(bool, lambda c: c.enabled if c._ci_visibility is None else c._ci_visibility) | ||
| # LLM Observability keeps a third state: left unset (and with no global switch) it | ||
| # probes the agent at startup and decides then, so it must not collapse to False. | ||
| llmobs = DDConfig.d(t.Optional[bool], lambda c: True if c.enabled and c._llmobs is None else c._llmobs) |
There was a problem hiding this comment.
Keep Remote Configuration enabled with agentless LLMObs
When DD_AGENTLESS_ENABLED=true and LLMObs starts without an explicit DD_REMOTE_CONFIGURATION_ENABLED, this derived True reaches LLMObs.enable(), where the existing branch in ddtrace/llmobs/_llmobs.py:1009-1012 sets _remote_config_enabled to false and disables the poller. As a result, the advertised global agentless combination silently stops Remote Configuration whenever LLMObs is enabled; the legacy LLMObs-only disable path needs to distinguish an inherited global setting.
Useful? React with 👍 / 👎.
Centralizing any agentless configs in a single place, making
DD_AGENTLESS_ENABLEDthe fallback for any more specific agentless settings.Also integrates agentless RC in particular.