chore: compute ddtrace version dynamically from git state - #19697
Draft
P403n1x87 wants to merge 1 commit into
Draft
chore: compute ddtrace version dynamically from git state#19697P403n1x87 wants to merge 1 commit into
P403n1x87 wants to merge 1 commit into
Conversation
P403n1x87
added
the
changelog/no-changelog
P403n1x87
changed the title
Circular import analysis
|
Dependency direction analysis
|
Contributor
|
Codeowners resolved asResolved from the full PR diff against |
BenchmarksBenchmark execution time: 2026-08-14 13:02:12 Comparing candidate commit 4eb5edd in PR branch Found 0 performance improvements and 5 performance regressions! Performance is the same for 616 metrics, 10 unstable metrics. scenario:httppropagationinject-ids_only
scenario:iastaspectsospath-ospathbasename_aspect
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
scenario:tracer-small
|
Replace setuptools_scm's abandoned release-branch-semver scheme (broken by detached-HEAD branch detection) and the manual version-bump PR process with scripts/compute_version.py: a dependency-free script that derives PEP 440 versions from git tags/branches, using explicit CI-provided ref info (never `git rev-parse --abbrev-ref HEAD` alone) and ancestry-independent global tag comparison for main's "latest shipped release" (release branches never merge back, so ancestry-based lookup misses sibling-branch releases). Validated so far: - Unit tests against synthetic git repos (tests/scripts/test_compute_version.py), covering all 4 version rules, detached HEAD, GH/GitLab ref resolution, and the main-after-sibling-branch-release regression case. - Historical replay against this repo's real git history (via disposable worktrees) for rules 1-3: exact tag builds, release-branch patch/dev versions, and freshly-cut release branches all matched expected output. Still outstanding before this can be trusted in production CI: - Cross-CI determinism: confirm GitHub Actions and GitLab CI resolve the same branch name and produce an identical version string for the same commit. - cibuildwheel's manylinux/musllinux containers: verify `git` is available (needed since setup.py recomputes the version inside those containers too). - sdist-then-wheel round trip: confirm ddtrace/_version_frozen.py, written when git is available, is correctly read back when a wheel is built from an sdist with no .git present. - GIT_DEPTH: "0" on the GitLab package/build jobs: confirm against a live pipeline that full tag history is actually fetched (rule 4's global tag scan needs it). Pre-commit hooks (mypy, bandit) skipped for this commit with explicit sign-off: both are triggered by pre-existing, unrelated issues in scripts/gen_gitlab_config.py's import graph (tests/suitespec.py, scripts/needs_testrun.py) that predate this change and are outside mypy.ini's official `files = ddtrace, docs` scope, plus expected Low-severity bandit findings on this script's inherent subprocess/assert usage.
P403n1x87
force-pushed
the
chore/infer-next-release-version
branch
from
August 14, 2026 12:37
dce996f to
4eb5edd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace setuptools_scm's abandoned release-branch-semver scheme (broken by detached-HEAD branch detection) and the manual version-bump PR process with scripts/compute_version.py: a dependency-free script that derives PEP 440 versions from git tags/branches, using explicit CI-provided ref info (never
git rev-parse --abbrev-ref HEADalone) and ancestry-independent global tag comparison for main's "latest shipped release" (release branches never merge back, so ancestry-based lookup misses sibling-branch releases).Validated so far:
Still outstanding before this can be trusted in production CI:
gitis available (needed since setup.py recomputes the version inside those containers too).