refactor: migrate Context to native - #19712
Conversation
Codeowners resolved asResolved from the full PR diff against |
Circular import analysis
|
Dependency direction analysis
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38ef60bfe1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| """Cycles formed via `_baggage` must be reclaimed by `gc.collect()`.""" | ||
| import gc | ||
|
|
||
| initial = _count_objects_of_type("Context") |
There was a problem hiding this comment.
Collect pre-existing cycles before taking the baseline
When an earlier test leaves any unreachable object named Context in a reference cycle, this baseline includes it, but the later gc.collect() frees it alongside the 200 cycles created here. The final exact comparison then observes fewer objects than initial and fails depending on suite order and GC timing; collect before recording the baseline or track only the contexts created by this test.
Useful? React with 👍 / 👎.
BenchmarksBenchmark execution time: 2026-08-15 00:14:29 Comparing candidate commit 38ef60b in PR branch Found 14 performance improvements and 14 performance regressions! Performance is the same for 588 metrics, 10 unstable metrics.
|
No description provided.