fix: bump js-yaml to ^4.3.1 to resolve GHSA-5p4m-2wfm-xmqj - #198
Closed
0x74696D wants to merge 1 commit into
Closed
Conversation
3 tasks
IlyasShabi
reviewed
Aug 11, 2026
Leave the package version bump/release out of this PR; that's a separate step for whoever cuts the next release (release.yml triggers off a pushed git tag, not off package.json's version field).
0x74696D
force-pushed
the
tim.mannai/js-yaml-4.3.1-bump
branch
from
August 11, 2026 15:20
d470cf7 to
0549869
Compare
Collaborator
Author
|
Good catch — dropped the version bump from this PR. This now only changes the |
IlyasShabi
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js-yamlversions>=4.0.0 <4.3.1are affected by GHSA-5p4m-2wfm-xmqj (CVSS 7.5).js-yamlrange (^4.1.1, set in5.0.2) still permits npm/yarn resolving a vulnerable version for anything that installs this package as a dependency (includingdd-trace) — aresolutions/overridesentry in a consumer's ownpackage.jsoncannot fix this, since npm only honors those fields in the root project, not in transitively-installed packages. The only fix that protects downstream installs is tightening the range here.js-yamlto^4.3.1and bumps the package version to5.0.3so consumers resolve the patched version.Context
Reported by a customer against
dd-trace(Node.js tracer), which depends on this package. See related fix indd-trace-js: DataDog/dd-trace-js#9768 (blocked on this release).Test plan
package.json/package-lock.jsonupdated; verified the lockfile'sjs-yamlentry resolves to4.3.1