Skip to content

fix: bump js-yaml to ^4.3.1 to resolve GHSA-5p4m-2wfm-xmqj - #198

Closed
0x74696D wants to merge 1 commit into
DataDog:mainfrom
0x74696D:tim.mannai/js-yaml-4.3.1-bump
Closed

fix: bump js-yaml to ^4.3.1 to resolve GHSA-5p4m-2wfm-xmqj#198
0x74696D wants to merge 1 commit into
DataDog:mainfrom
0x74696D:tim.mannai/js-yaml-4.3.1-bump

Conversation

@0x74696D

Copy link
Copy Markdown
Collaborator

Summary

  • js-yaml versions >=4.0.0 <4.3.1 are affected by GHSA-5p4m-2wfm-xmqj (CVSS 7.5).
  • This package's declared js-yaml range (^4.1.1, set in 5.0.2) still permits npm/yarn resolving a vulnerable version for anything that installs this package as a dependency (including dd-trace) — a resolutions/overrides entry in a consumer's own package.json cannot fix this, since npm only honors those fields in the root project, not in transitively-installed packages. The only fix that protects downstream installs is tightening the range here.
  • Tightens js-yaml to ^4.3.1 and bumps the package version to 5.0.3 so consumers resolve the patched version.

Context

Reported by a customer against dd-trace (Node.js tracer), which depends on this package. See related fix in dd-trace-js: DataDog/dd-trace-js#9768 (blocked on this release).

Test plan

  • package.json / package-lock.json updated; verified the lockfile's js-yaml entry resolves to 4.3.1
  • Diff kept minimal — no other dependency versions touched

Comment thread package.json Outdated
Leave the package version bump/release out of this PR; that's a separate
step for whoever cuts the next release (release.yml triggers off a
pushed git tag, not off package.json's version field).
@0x74696D
0x74696D force-pushed the tim.mannai/js-yaml-4.3.1-bump branch from d470cf7 to 0549869 Compare August 11, 2026 15:20
@0x74696D

Copy link
Copy Markdown
Collaborator Author

Good catch — dropped the version bump from this PR. This now only changes the js-yaml dependency range (^4.1.1^4.3.1) and the corresponding lockfile entry; package.json/package-lock.json version stays at 5.0.2. Bumping the version and cutting the actual release (which is tag-push-triggered per .github/workflows/release.yml) can happen as a separate step once this is merged.

@0x74696D
0x74696D requested a review from IlyasShabi August 11, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants