fix: bump js-yaml to ^4.3.1 to resolve GHSA-5p4m-2wfm-xmqj - #200
Merged
Conversation
Leave the package version bump/release out of this PR; that's a separate step for whoever cuts the next release (release.yml triggers off a pushed git tag, not off package.json's version field). Signed-off-by: Tim VM@DD <tim.mannai@datadoghq.com>
Collaborator
|
I fixed the failed test. Can you rebase on main and push please? |
…m.mannai/js-yaml-4.3.1-bump
IlyasShabi
approved these changes
Aug 13, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js-yaml versions >=4.0.0 <4.3.1 are affected by GHSA-5p4m-2wfm-xmqj (CVSS 7.5).
This package's declared js-yaml range (^4.1.1, set in 5.0.2) still permits npm/yarn resolving a vulnerable version for anything that installs this package as a dependency (including dd-trace) — a resolutions/overrides entry in a consumer's own package.json cannot fix this, since npm only honors those fields in the root project, not in transitively-installed packages. The only fix that protects downstream installs is tightening the range here.
Tightens js-yaml to ^4.3.1 and bumps the package version to 5.0.3 so consumers resolve the patched version.
Context
Reported by a customer against dd-trace (Node.js tracer), which depends on this package. See related fix in dd-trace-js: DataDog/dd-trace-js#9768 (blocked on this release).