Skip to content

Conversation

r1viollet
Copy link
Collaborator

@r1viollet r1viollet commented Sep 18, 2024

What does this PR do?

Introduce a parsing of smaps to try and upscale the allocations with numbers that can compare to the smap values.

Motivation

Getting closer to RSS values
Being more transparent on what we are able to instrument

Additional Notes

NA

How to test the change?

TODO

@pr-commenter
Copy link

pr-commenter bot commented Oct 14, 2024

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.19.0+bccb05d8.46712946 ddprof 0.19.0+09704ab0.47208124

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Oct 14, 2024

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.19.0+bccb05d8.46712946 ddprof 0.19.0+09704ab0.47208124

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

Introduce a parsing of smaps to try and upscale the allocations with numbers
that can compare to the smap values.
Add labels to differentiate the different types of reported memory
@r1viollet r1viollet force-pushed the r1viollet/smap_proto branch from 860da69 to 2891d59 Compare October 21, 2024 13:09
- Clang tidy
- Cleanup of unused fields
@r1viollet r1viollet force-pushed the r1viollet/smap_proto branch from 2891d59 to 65d8054 Compare October 21, 2024 13:28
Avoid skipping virtual frames when reporting mappings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant