Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| build-essential \ | ||
| git \ | ||
| curl \ | ||
| wget \ | ||
| libxml2-dev \ | ||
| libxslt1-dev \ | ||
| zlib1g-dev \ | ||
| sqlite3 \ | ||
| libsqlite3-dev \ | ||
| libssl-dev \ | ||
| pkg-config \ | ||
| make \ | ||
| zsh \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
⚪ Code Quality Violation
package libsqlite3-dev should have version pinned (...read more)
When using apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.
| RUN groupadd --gid $USER_GID $USERNAME \ | ||
| && useradd --uid $USER_UID --gid $USER_GID -m $USERNAME \ | ||
| # Add the new user to the sudo group to allow them to run commands with sudo | ||
| && apt-get update \ | ||
| && apt-get install -y sudo \ | ||
| && echo $USERNAME ALL=\(ALL\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \ | ||
| && chmod 0440 /etc/sudoers.d/$USERNAME \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
⚪ Code Quality Violation
package sudo should have version pinned (...read more)
When using apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.
|
Let's update the readme with some basic steps to use the devcontainer. I did something similar for serilog |
|
FYI I get this when I try to use either of the launch targets: |
jhgilbert
left a comment
jhgilbert
left a comment
There was a problem hiding this comment.
Approved with minor comments, thank you!
Co-authored-by: Jen Gilbert <j.h.gilbert@gmail.com>
Co-authored-by: Jen Gilbert <j.h.gilbert@gmail.com>
Datadog Summary❌ Code Quality ✅ Code Security ✅ Dependencies Next StepsFix these code quality issues introduced by this PR: ⚪ Notice: docker-best-practices/apt-pin-version
⚪ Notice: docker-best-practices/apt-pin-version
Was this helpful? Give us feedback! |
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| build-essential \ | ||
| git \ | ||
| curl \ | ||
| wget \ | ||
| libxml2-dev \ | ||
| libxslt1-dev \ | ||
| zlib1g-dev \ | ||
| sqlite3 \ | ||
| libsqlite3-dev \ | ||
| libssl-dev \ | ||
| pkg-config \ | ||
| make \ | ||
| zsh \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
⚪ Notice: Code Quality Violation
package zsh should have version pinned (...read more)
When using apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.
| RUN groupadd --gid $USER_GID $USERNAME \ | ||
| && useradd --uid $USER_UID --gid $USER_GID -m $USERNAME \ | ||
| # Add the new user to the sudo group to allow them to run commands with sudo | ||
| && apt-get update \ | ||
| && apt-get install -y sudo \ | ||
| && echo $USERNAME ALL=\(ALL\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \ | ||
| && chmod 0440 /etc/sudoers.d/$USERNAME \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
⚪ Notice: Code Quality Violation
package sudo should have version pinned (...read more)
When using apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.
|
Container starts! When I click Running |
|
This PR is extended by #76 |
4 participants
What does this PR do?
Adds a devcontainer configuration to create a reproducible dev environment.
Motivation
reproducible dev environment
Additional Notes
Try launching in vscode and running it to verify.