Skip to content

Conversation

@eliottness
Copy link
Contributor

@eliottness eliottness commented Sep 17, 2025

  • upgrade libddwaf v1.25.1 -> v1.28.1
  • Rotate old CI images that were failing
  • Move the waflib singleton to the bindings package
  • Remove the json package
  • Replace calls to the json package by ddwaf_object_from_json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved from waf.go to avoid circular dependencies

fail-fast: false
matrix:
runs-on: [ macos-15, macos-14, macos-13, ubuntu-24.04, ubuntu-22.04, windows-latest, arm-4core-linux ]
runs-on: [ macos-26, macos-latest-large, macos-13, ubuntu-24.04, ubuntu-22.04, windows-latest, ubuntu-24.04-arm ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macos-latest-large is the only amd64 image available under macos now

Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness marked this pull request as ready for review September 17, 2025 16:20
@eliottness eliottness requested a review from a team as a code owner September 17, 2025 16:20
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go home, review, you're drunk!

@eliottness eliottness merged commit 9a64933 into main Sep 18, 2025
107 checks passed
@eliottness eliottness deleted the eliottness/libddwaf-1.28 branch September 18, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants