Improve typosquatting top-packages sources for npm and PyPI - #799
Open
sobregosodd wants to merge 4 commits into
Open
Improve typosquatting top-packages sources for npm and PyPI#799sobregosodd wants to merge 4 commits into
sobregosodd wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
nit: in the PR description- |
tesnim5hamdouni
previously approved these changes
Jul 3, 2026
tesnim5hamdouni
left a comment
tesnim5hamdouni
left a comment
Contributor
There was a problem hiding this comment.
lgtm, left 2 comments
sobregosodd
enabled auto-merge
July 3, 2026 13:59
Contributor
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a00f386cbe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try: | ||
| resp = requests.get( | ||
| _NPMS_URL.format(offset=offset), | ||
| headers={"User-Agent": "guarddog/1.0"}, |
Contributor
There was a problem hiding this comment.
should probably be guarddog 3.0? or just a dynamic version number?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/LeoDog896/npm-rank(a third-party GitHub release that had already been renamed/redirected once) with direct pagination of thenpms.iosearch API — the same source used byevals/benchmark.pyhugovk.github.ioURL (which 301-redirects tohugovk.dev) with a direct bulk query to the public ClickHouse instance that hosts PyPI's official download data (sql-clickhouse.clickhouse.com, tablepypi.pypi_downloads_per_month) — the same upstream source hugovk usesTest plan
poetry run pytest tests/analyzer/metadata/test_typosquatting.py— all 39 tests passguarddog npm scan expresssflags as typosquat ofexpressguarddog pypi scan reqeustsflags as typosquat ofrequests🤖 Generated with Claude Code