Skip to content

fix(pypi): check both author and maintainer email in get_email_addresses #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpitjain099 wants to merge 1 commit into
base: v3
Choose a base branch
from
+18 −1
Open

fix(pypi): check both author and maintainer email in get_email_addresses #810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guarddog/analyzer/metadata/pypi/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
def get_email_addresses(package_info: dict) -> set[str]:
info = package_info.get("info", {})

return {info.get("author_email") or info.get("maintainer_email")} - {None}
return {info.get("author_email"), info.get("maintainer_email")} - {None, ""}

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Parse PyPI email fields before returning them

PyPI core metadata allows Author-email and Maintainer-email to contain multiple comma-separated RFC-822 addresses (spec). Returning each raw field as one set entry means the shared detectors pass a value like maintainer_email='expired@old.tld, owner@gmail.com' to extract_email_address_domain(), which only examines the text after the last @; in that valid metadata shape, the newly included maintainer address with the expired domain is ignored. Parse these fields into individual addresses before returning the set.

Useful? React with 👍 / 👎.

17 changes: 17 additions & 0 deletions tests/analyzer/metadata/test_pypi_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
from guarddog.analyzer.metadata.pypi.utils import get_email_addresses


def test_get_email_addresses_returns_both_author_and_maintainer():
package_info = {
"info": {
"author_email": "realdev@example.com",
"maintainer_email": "maintainer@example.org",
}
}
emails = get_email_addresses(package_info)
assert emails == {"realdev@example.com", "maintainer@example.org"}


def test_get_email_addresses_drops_none_and_empty():
package_info = {"info": {"author_email": "realdev@example.com", "maintainer_email": ""}}
assert get_email_addresses(package_info) == {"realdev@example.com"}