Skip to content

Spinnaker Integration Validation: V1 #19145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yogesh-s-modak
Copy link

@yogesh-s-modak yogesh-s-modak commented Nov 27, 2024

What does this PR do?

Porting over from Spinnaker Integration PR.

Motivation

Squashing 69 commits into one PR.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@neko-dd neko-dd added the editorial review Waiting on a more in-depth review from a docs team editor label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (f3e57bd) to head (dbf9cf5).
Report is 55 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
nvidia_nim ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@neko-dd
Copy link
Contributor

neko-dd commented Nov 27, 2024

Created DOCS-9633 for docs review

@yogesh-s-modak yogesh-s-modak mentioned this pull request Nov 28, 2024
3 tasks
@steveny91
Copy link
Contributor

@yogesh-s-modak Just to confirm again, there's no python code needed for this integration right? It's just logs parsing and dashboard definitions, correct? If so then I think we can remove a lot of files from here. When creating the template for the integration, you can pass in -t logs next time if you want to create a logs only integration. After confirmation, I can help you with what files needs to be removed.

@jhgilbert jhgilbert self-requested a review December 9, 2024 16:38
@yogesh-s-modak
Copy link
Author

@yogesh-s-modak Just to confirm again, there's no python code needed for this integration right? It's just logs parsing and dashboard definitions, correct? If so then I think we can remove a lot of files from here. When creating the template for the integration, you can pass in -t logs next time if you want to create a logs only integration. After confirmation, I can help you with what files needs to be removed.

@steveny91 We have kept this PR on hold for the moment, because after discussion with Ilya, we came to a conclusion that this connector needs metrics to be included, along with logs. We will need to ascertain what metrics will be included, update the design docs and the PR, and go from there. Due to this, along with log parsing and dashboard definitions, there will be Python code in line with what is required for a metrics connector.

@steveny91
Copy link
Contributor

@yogesh-s-modak No problem! Would you mind converting this PR to a draft and then when it's ready mark it ready for review again?

@yogesh-s-modak yogesh-s-modak marked this pull request as draft December 11, 2024 03:31
@yogesh-s-modak
Copy link
Author

@yogesh-s-modak No problem! Would you mind converting this PR to a draft and then when it's ready mark it ready for review again?

Done. I'll mark it with the relevant tags as and when we proceed.

@yogesh-s-modak yogesh-s-modak marked this pull request as ready for review January 8, 2025 13:55
@iliakur iliakur marked this pull request as draft January 24, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants