-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Spinnaker Integration Validation: V1 #19145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Spinnaker Integration Validation: V1 #19145
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
Created DOCS-9633 for docs review |
@yogesh-s-modak Just to confirm again, there's no python code needed for this integration right? It's just logs parsing and dashboard definitions, correct? If so then I think we can remove a lot of files from here. When creating the template for the integration, you can pass in |
@steveny91 We have kept this PR on hold for the moment, because after discussion with Ilya, we came to a conclusion that this connector needs metrics to be included, along with logs. We will need to ascertain what metrics will be included, update the design docs and the PR, and go from there. Due to this, along with log parsing and dashboard definitions, there will be Python code in line with what is required for a metrics connector. |
@yogesh-s-modak No problem! Would you mind converting this PR to a draft and then when it's ready mark it ready for review again? |
Done. I'll mark it with the relevant tags as and when we proceed. |
What does this PR do?
Porting over from Spinnaker Integration PR.
Motivation
Squashing 69 commits into one PR.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged