adds gotk_resource_info metric to fluxcd metrics #19761
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sarah-witt
reviewed
Mar 6, 2025
| @@ -16,6 +16,7 @@ | |||
| assert sorted(FLUX_V1_METRICS) == list(FLUX_V1_METRICS) | |||
|
|
|||
| FLUX_V2_METRICS = { | |||
| "gotk_resource_info": "gotk.resource.info", | |||
There was a problem hiding this comment.
Thanks so much! Do you mind adding this metric to the metadata.csv? It would be great if we could add the output to the test fixtures as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
gotk_resource_infometric to the Fluxcd integration. Link to Fluxcd docsMotivation
Customer request
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged