Skip to content

[FA] Always instrument methods #19956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[FA] Always instrument methods #19956

wants to merge 10 commits into from

Conversation

coignetp
Copy link
Contributor

@coignetp coignetp commented Mar 28, 2025

What does this PR do?

This PR update the instrumentation logic of all the check methods.
Here are the following changes:

  • All methods of AGENT_CHECK_DEFAULT_TRACED_METHODS are always instrumented (meaning wrapped with a tracer.trace)
  • If the method is an entry-level method (meaning that it's called by the agent directly, and not one of the internal methods), it calls the configure_tracer method before running the method.
  • configure_tracer samples all traces if integration_tracing or integration_tracing_exhaustive is true
  • Attach to dd_trace_id and dd_parent_span_id if they exist in the instance.

Next step is to read the sampling from the agent config, and let the agent pass the trade ID and the parent ID through the instance

Motivation

The goal is to be able to enable or disable tracing at runtime. (PR in progress)

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 94.31818% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.95%. Comparing base (2fff4ec) to head (1753580).
Report is 6 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
active_directory 93.18% <ø> (ø)
activemq 52.80% <ø> (ø)
activemq_xml 82.20% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
appgate_sdp 93.93% <ø> (ø)
arangodb 98.23% <ø> (ø)
argo_rollouts 90.00% <ø> (ø)
argo_workflows 89.61% <ø> (ø)
argocd 87.23% <ø> (ø)
aspdotnet 100.00% <ø> (ø)
avi_vantage 93.83% <ø> (ø)
aws_neuron 92.42% <ø> (ø)
azure_iot_edge 82.08% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 83.33% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 84.61% <ø> (ø)
cassandra 66.66% <ø> (ø)
celery 95.45% <ø> (ø)
cert_manager 77.41% <ø> (ø)
cisco_aci 89.52% <ø> (ø)
citrix_hypervisor 87.45% <ø> (ø)
cloud_foundry_api 96.11% <ø> (ø)
cloudera 99.51% <ø> (ø)
cockroachdb 92.98% <ø> (ø)
consul 91.92% <ø> (ø)
coredns 95.65% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_dev 77.58% <ø> (ø)
datadog_checks_downloader 81.37% <ø> (+3.22%) ⬆️
datadog_cluster_agent 90.19% <ø> (ø)
dcgm 93.54% <ø> (ø)
ddev 87.16% <ø> (ø)
directory 96.88% <ø> (ø)
disk 85.68% <ø> (ø)
dns_check 93.84% <ø> (ø)
druid 97.70% <ø> (ø)
duckdb 84.53% <ø> (ø)
ecs_fargate 83.71% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
esxi 93.92% <ø> (ø)
etcd 95.56% <ø> (ø)
external_dns 89.28% <ø> (ø)
fluentd 84.21% <ø> (ø)
fluxcd 88.31% <ø> (ø)
fly_io 97.13% <ø> (ø)
foundationdb 82.64% <ø> (ø)
gitlab_runner 92.76% <ø> (ø)
glusterfs 80.00% <ø> (ø)
go_expvar 92.66% <ø> (ø)
gunicorn 92.16% <ø> (-0.75%) ⬇️
hazelcast 92.30% <ø> (ø)
hdfs_datanode 89.63% <ø> (ø)
hdfs_namenode 86.60% <ø> (ø)
hive 51.42% <ø> (ø)
hivemq 61.90% <ø> (ø)
http_check 94.26% <ø> (ø)
ibm_db2 86.29% <ø> (ø)
ibm_i 82.36% <ø> (ø)
ignite 46.66% <ø> (ø)
impala 97.97% <ø> (ø)
infiniband 94.76% <ø> (+1.04%) ⬆️
istio 77.86% <ø> (ø)
jboss_wildfly 47.36% <ø> (ø)
kafka 64.70% <ø> (ø)
karpenter 95.06% <ø> (ø)
keda 88.05% <ø> (ø)
kong 88.42% <ø> (ø)
kube_controller_manager 97.88% <ø> (ø)
kube_dns 95.94% <ø> (ø)
kube_metrics_server 94.87% <ø> (ø)
kube_proxy 96.80% <ø> (ø)
kube_scheduler 97.92% <ø> (ø)
kubeflow 93.22% <ø> (ø)
kubelet 91.09% <ø> (ø)
kubernetes_cluster_autoscaler 93.22% <ø> (ø)
kubernetes_state 89.49% <ø> (ø)
kubevirt_api 82.75% <ø> (ø)
kubevirt_controller 85.36% <ø> (ø)
kubevirt_handler 91.32% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
kyverno 82.27% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 84.70% <ø> (ø)
linux_proc_extras 96.20% <ø> (ø)
mapr 82.70% <ø> (ø)
mapreduce 81.99% <ø> (ø)
marathon 83.06% <ø> (ø)
mcache 93.99% <ø> (ø)
mesos_master 89.71% <ø> (ø)
milvus 92.30% <ø> (ø)
mysql 85.45% <ø> (?)
nagios 89.01% <ø> (ø)
network 93.89% <ø> (ø)
nfsstat 95.20% <ø> (ø)
nginx_ingress_controller 98.55% <ø> (ø)
nvidia_nim 93.10% <ø> (ø)
nvidia_triton 88.52% <ø> (ø)
octopus_deploy 99.25% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 98.05% <ø> (ø)
openstack 55.11% <ø> (ø)
pgbouncer 94.91% <ø> (ø)
php_fpm 90.45% <ø> (ø)
postfix 88.04% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
presto 59.09% <ø> (ø)
process 85.99% <ø> (ø)
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
pulsar 100.00% <ø> (ø)
quarkus 100.00% <ø> (ø)
rethinkdb 98.27% <ø> (ø)
riak 99.21% <ø> (ø)
riakcs 88.82% <ø> (ø)
silk 93.91% <ø> (+62.73%) ⬆️
silverstripe_cms 76.00% <ø> (ø)
singlestore 90.81% <ø> (ø)
slurm 90.59% <ø> (ø)
snowflake 96.27% <ø> (ø)
solr 56.25% <ø> (ø)
sonatype_nexus 81.88% <ø> (ø)
spark 93.50% <ø> (ø)
squid 100.00% <ø> (ø)
ssh_check 93.07% <ø> (+0.86%) ⬆️
statsd 87.36% <ø> (ø)
strimzi 89.78% <ø> (ø)
supabase 93.97% <ø> (ø)
supervisord 90.14% <ø> (ø)
system_core 92.52% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 90.72% <ø> (ø)
tekton 82.45% <ø> (ø)
teleport 98.16% <ø> (ø)
teradata 94.27% <ø> (ø)
tibco_ems 91.98% <ø> (ø)
tls 90.26% <ø> (ø)
torchserve 97.32% <ø> (ø)
traefik_mesh 76.75% <ø> (ø)
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 80.41% <ø> (ø)
varnish 84.22% <ø> (ø)
vault 94.44% <ø> (-1.23%) ⬇️
velero 85.00% <ø> (ø)
vllm 94.44% <ø> (ø)
weaviate 76.27% <ø> (ø)
wmi_check 92.91% <ø> (ø)
yarn 89.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coignetp coignetp mentioned this pull request Apr 2, 2025
3 tasks
@coignetp coignetp force-pushed the paul/fa-trace-methods branch from 77d942d to 49f035f Compare April 3, 2025 08:45
@coignetp coignetp marked this pull request as ready for review April 4, 2025 14:17
@coignetp coignetp requested a review from a team as a code owner April 4, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants