Skip to content

[Karpenter Integration]: add missed metrics based on karpenter v1.4 documentations #20110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Yufeireal
Copy link

@Yufeireal Yufeireal commented Apr 20, 2025

What does this PR do?

This PR mainly add missed metrics to karpenter datadog integration according to karpenter 1.4 doc.
Related issue: #20109

Very new to datadog, so I will definately missed some naming convention, please drop comments and I will resolve them as soon as possible, thanks!

I've added the newly introduced metrics to v1 metrics testing since v1.4 is also v1 🤣 (though I think we should probably keep one single test metrics mock, I guess the reason we have two is because karpenter changed 0.x metrics's name in v1? Separate them out might be easier for testing.)

Then, I updated the metadata.csv as prompted while I ran the test.

Motivation

https://karpenter.sh/v1.4/reference/metrics/
There are many valuable metrics in newer releases after 1.0.0, considering the criticality of Kaprneter, having these metrics could benefit infra observability a lot.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@Yufeireal
Copy link
Author

Yufeireal commented Apr 20, 2025

I can mock a testing based on v1.4 metrics.
Wondering which way works better for us?

Creating a mock file karpenter_metrics_v1.4.txt and do end to end test OR just make changes to karpenter_metrics_v1.txt.

Edited: I've added the metrics to karpenter_v1 mock since v1.4 is also v1 I think

@Yufeireal Yufeireal changed the title [Karpenter Integration]: add missed metrics based on karpenter v1.4 documentations [WIP][Karpenter Integration]: add missed metrics based on karpenter v1.4 documentations Apr 20, 2025
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.11%. Comparing base (3cabf9e) to head (89bc2e0).
Report is 3 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
karpenter 95.06% <ø> (ø)
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Yufeireal Yufeireal changed the title [WIP][Karpenter Integration]: add missed metrics based on karpenter v1.4 documentations [Karpenter Integration]: add missed metrics based on karpenter v1.4 documentations Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant