Update documentation for RabbitMQ Prometheus family types #20155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robcarlan-datadog
changed the title
jhgilbert
previously approved these changes
Apr 25, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
steveny91
previously approved these changes
Apr 25, 2025
Co-authored-by: Jen Gilbert <[email protected]>
temporal-github-worker-1
bot
dismissed stale reviews from jhgilbert and steveny91
Review from jhgilbert is dismissed. Related teams and files:
- documentation
- rabbitmq/README.md
Review from steveny91 is dismissed. Related teams and files:
- agent-integrations
- rabbitmq/README.md
temporal-github-worker-1
bot
added
agent/review-requested
docs/review-requested
and removed
agent/approved
docs/approved
labels
steveny91
approved these changes
Apr 28, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make it more obvious that different family types provide different documentation.
Update the sample unaggregated_endpoint configuration to include more family types. I am doing this because the OpenMetrics version of the RabbitMQ dashboard provides stats on a per exchange & per queue basis from the top bar. This information is only available when those additional family types are included.
Motivation
Setting up a test RabbitMQ application, it is easy to just want to use the default configuration provided by the instructions. The user can get more functionality with additional family types. This is especially true for Data Streams Monitoring.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged