Bump pysmi version to 1.6.2 by Pierre-L42 · Pull Request #22648 · DataDog/integrations-core

Pierre-L42 · 2026-02-16T16:20:24Z

What does this PR do?

This PR bumps pysmi library to 1.6.2 and updates the code to match this version.

Motivation

https://datadoghq.atlassian.net/jira/software/c/projects/AGENT/boards/469?issueType=30619%2C30620%2C12458&selectedIssue=AGENT-15590

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Pierre-L42 · 2026-02-16T16:20:39Z

Bump pysmi version to 1.6.2 #22648 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

codecov · 2026-02-16T16:51:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.24%. Comparing base (aee78b5) to head (3462c89).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-02-18T14:34:02Z

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11a59b13ac

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TCheruy · 2026-02-18T14:36:50Z

                )

-            compiled_mibs = {k: v for k, v in mibs_status.items() if v == 'compiled'}
+            compiled_mibs = {k: v for k, v in mibs_status.items() if str(v) in ('compiled', 'untouched', 'borrowed')}


This is suspicious 👀 why do we need this change?

I reverted this change as it seems to work without it on the first 20 MIBs of ndm-traps-db, I'll run tomorrow on all the MIBs and let you know if there are any changes with the generated file

TCheruy · 2026-02-18T14:45:01Z

    from pysmi.searcher import AnyFileSearcher
    from pysmi.writer import FileWriter

+    # pysmi's HttpReader decodes HTTP response as UTF-8 only; MIBs with non-UTF-8 bytes


is this a new issue with the version bump or was it already present?

It's a new issue with the bump

… files

NouemanKHAL

As the PR contains a signifant code change + the version bump, I think it needs to be reflected in the changelog.
Could you please add a changelog entry?

github-actions · 2026-02-25T09:55:38Z

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Review from TCheruy is dismissed. Related teams and files:

ndm-core
- datadog_checks_dev/datadog_checks/dev/tooling/commands/meta/snmp/generate_traps_db.py

* Bump pysmi version to 1.6.2 and update code * Create custom HTTP reader class to handle non-UTF-8 characters in MIB files * Add tests for the trans_oper logic * ddev test --fmt * Fix lints * Fix issue with enum * Remove borrowed or untouched MIBs * Remove print * Fixes * Remove debug print * Fix * Remove useless * Remove useless * Replace - by _ * Add back custom HTTP reader * ddev test --fmt datadog_checks_dev * Add changelog * Address reviews * ddev test --fmt * Fix test

* Bump pysmi version to 1.6.2 and update code * Create custom HTTP reader class to handle non-UTF-8 characters in MIB files * Add tests for the trans_oper logic * ddev test --fmt * Fix lints * Fix issue with enum * Remove borrowed or untouched MIBs * Remove print * Fixes * Remove debug print * Fix * Remove useless * Remove useless * Replace - by _ * Add back custom HTTP reader * ddev test --fmt datadog_checks_dev * Add changelog * Address reviews * ddev test --fmt * Fix test Signed-off-by: lukepatrick <lukephilips@gmail.com>

temporal-github-worker-1 Bot added agent/review-requested ecosystems/review-requested product/review-requested labels Feb 16, 2026

datadog-agent-integrations-bot Bot added dev/tooling dev_package labels Feb 16, 2026

This comment has been minimized.

Sign in to view

Pierre-L42 force-pushed the pierre.lin/bump-pysmi branch from c46c3f1 to 27ac901 Compare February 18, 2026 10:26

Pierre-L42 added the changelog/no-changelog label Feb 18, 2026

Pierre-L42 force-pushed the pierre.lin/bump-pysmi branch from b899a05 to 11a59b1 Compare February 18, 2026 14:27

datadog-agent-integrations-bot Bot removed the changelog/no-changelog label Feb 18, 2026

Pierre-L42 marked this pull request as ready for review February 18, 2026 14:27

Pierre-L42 requested review from a team as code owners February 18, 2026 14:27

Pierre-L42 requested a review from jedupau February 18, 2026 14:27

datadog-agent-integrations-bot Bot added team/agent-integrations team/ndm-core labels Feb 18, 2026

Pierre-L42 added the changelog/no-changelog label Feb 18, 2026

datadog-agent-integrations-bot Bot removed the changelog/no-changelog label Feb 18, 2026

chatgpt-codex-connector Bot reviewed Feb 18, 2026

View reviewed changes

Comment thread datadog_checks_dev/datadog_checks/dev/tooling/commands/meta/snmp/generate_traps_db.py Outdated

TCheruy reviewed Feb 18, 2026

View reviewed changes

Pierre-L42 added 7 commits February 23, 2026 10:07

Bump pysmi version to 1.6.2 and update code

627dcdc

Create custom HTTP reader class to handle non-UTF-8 characters in MIB…

e66d11d

… files

Add tests for the trans_oper logic

30cc950

ddev test --fmt

10de115

Fix lints

696b7b9

Fix issue with enum

9e26ec3

Remove borrowed or untouched MIBs

cf7af66

Pierre-L42 added 2 commits February 24, 2026 13:39

Add back custom HTTP reader

77c1c4d

ddev test --fmt datadog_checks_dev

3462c89

Pierre-L42 added the changelog/no-changelog label Feb 24, 2026

TCheruy previously approved these changes Feb 24, 2026

View reviewed changes

NouemanKHAL requested changes Feb 24, 2026

View reviewed changes

temporal-github-worker-1 Bot added agent/requested-changes and removed agent/review-requested labels Feb 24, 2026

Add changelog

3c112ce

datadog-agent-integrations-bot Bot removed the changelog/no-changelog label Feb 25, 2026

Pierre-L42 requested a review from NouemanKHAL February 25, 2026 09:57

NouemanKHAL reviewed Feb 25, 2026

View reviewed changes

Comment thread datadog_checks_dev/datadog_checks/dev/tooling/commands/meta/snmp/generate_traps_db.py Outdated

NouemanKHAL reviewed Feb 25, 2026

View reviewed changes

Comment thread datadog_checks_dev/datadog_checks/dev/tooling/commands/meta/snmp/generate_traps_db.py Outdated

NouemanKHAL reviewed Feb 25, 2026

View reviewed changes

Comment thread datadog_checks_dev/datadog_checks/dev/tooling/commands/meta/snmp/generate_traps_db.py Outdated

Address reviews

e2b6a71

ddev test --fmt

6883bf2

Pierre-L42 requested review from NouemanKHAL and TCheruy February 25, 2026 10:21

Fix test

5b92916

NouemanKHAL approved these changes Feb 25, 2026

View reviewed changes

temporal-github-worker-1 Bot added agent/approved and removed agent/requested-changes labels Feb 25, 2026

Pierre-L42 added this pull request to the merge queue Feb 25, 2026

Merged via the queue into master with commit e280aa0 Feb 25, 2026
305 of 307 checks passed

Pierre-L42 deleted the pierre.lin/bump-pysmi branch February 25, 2026 12:30

Conversation

Pierre-L42 commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Uh oh!

Pierre-L42 commented Feb 16, 2026

Uh oh!

This comment has been minimized.

codecov Bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

TCheruy Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Pierre-L42 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

TCheruy Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Pierre-L42 Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

NouemanKHAL left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pierre-L42 commented Feb 16, 2026 •

edited

Loading

codecov Bot commented Feb 16, 2026 •

edited

Loading

github-actions Bot commented Feb 18, 2026 •

edited

Loading