[AI-6534] Add Dell Powerflex Integration#23183
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4eb56e7612
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Validation ReportAll 20 validations passed. Show details
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb8bc69f7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if self._collect_events(last_event_ts): | ||
| self.write_persistent_cache('last_event_timestamp', now) | ||
| if self.config.collect_alerts: | ||
| last_alert_ts = self.read_persistent_cache('last_alert_timestamp') or now |
There was a problem hiding this comment.
Don't seed alert collection at the current time
When collect_alerts is enabled for an existing PowerFlex gateway with no cache yet, this initializes the lower-bound filter to the agent's current time before calling /rest/v1/alerts?filter=last_updated ge .... Any active alert whose last_updated is earlier than that first check is filtered out and never emitted unless it is updated later, so users can miss pre-existing incidents immediately after enabling the integration. Consider fetching active alerts on the first run or seeding from an older/empty cursor and then advancing the cache from the returned alert timestamps.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I think it's fine to miss preexisting alerts.
|
Created DOCS-14392 for review. |
What does this PR do?
Adds an integration to monitor Dell Powerflex
Motivation
All assets will be completed in separate PRs.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged