Skip to content

[AI-6534] Add Dell Powerflex Integration#23183

Open
sarah-witt wants to merge 64 commits into
masterfrom
sarah/add-dell-powerflex-int
Open

[AI-6534] Add Dell Powerflex Integration#23183
sarah-witt wants to merge 64 commits into
masterfrom
sarah/add-dell-powerflex-int

Conversation

@sarah-witt
Copy link
Copy Markdown
Contributor

@sarah-witt sarah-witt commented Apr 6, 2026

What does this PR do?

Adds an integration to monitor Dell Powerflex

Motivation

All assets will be completed in separate PRs.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented Apr 6, 2026

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 158 Tests failed

test_e2e_cisco_legacy_wlc from test_e2e_core.py   View in Datadog   (Fix with Cursor)
Needed at least 1 candidates for 'snmp.device.reachable', got 0
Expected:
        MetricStub(name='snmp.device.reachable', type=0, value=1, tags=['agent_host:runnervmrc6n4', 'device_hostname:DDOGWLC', 'device_id:default:172.18.0.2', 'device_ip:172.18.0.2', 'device_namespace:default', 'device_vendor:cisco', 'snmp_device:172.18.0.2', 'snmp_host:DDOGWLC', 'snmp_profile:cisco-legacy-wlc'], hostname=None, device=None, flush_first_value=None)
Difference to closest:
        Expected tag agent_host:runnervmrc6n4
        Found agent_host:None
        Expected tag device_hostname:DDOGWLC
        Found device_hostname:None
        Expected tag device_id:default:172.18.0.2
        Found device_id:None
...
test_e2e_cisco_nexus from test_e2e_core.py   View in Datadog   (Fix with Cursor)
Needed at least 1 candidates for 'snmp.device.reachable', got 0
Expected:
        MetricStub(name='snmp.device.reachable', type=0, value=1, tags=['agent_host:runnervmrc6n4', 'device_hostname:Nexus-eu1.companyname.managed', 'device_id:default:172.18.0.2', 'device_ip:172.18.0.2', 'device_namespace:default', 'device_vendor:cisco', 'snmp_device:172.18.0.2', 'snmp_host:Nexus-eu1.companyname.managed', 'snmp_profile:cisco-nexus'], hostname=None, device=None, flush_first_value=None)
Difference to closest:
        Expected tag agent_host:runnervmrc6n4
        Found agent_host:None
        Expected tag device_hostname:Nexus-eu1.companyname.managed
        Found device_hostname:None
        Expected tag device_id:default:172.18.0.2
        Found device_id:None
...
test_e2e_core_cisco_csr from test_e2e_core.py   View in Datadog   (Fix with Cursor)
Needed at least 1 candidates for 'snmp.device.reachable', got 0
Expected:
        MetricStub(name='snmp.device.reachable', type=0, value=1, tags=['agent_host:runnervmrc6n4', 'device_id:default:172.18.0.2', 'device_ip:172.18.0.2', 'device_namespace:default', 'device_vendor:cisco', 'snmp_device:172.18.0.2', 'snmp_profile:cisco-csr1000v'], hostname=None, device=None, flush_first_value=None)
Difference to closest:
        Expected tag agent_host:runnervmrc6n4
        Found agent_host:None
        Expected tag device_id:default:172.18.0.2
        Found device_id:None
        Expected tag device_ip:172.18.0.2
        Found device_ip:None
...
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 98.81%
Overall Coverage: 88.69%

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eb8bc69 | Docs | Datadog PR Page | Give us feedback!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 98.81081% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.87%. Comparing base (b477b35) to head (eb8bc69).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarah-witt
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4eb56e7612

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread dell_powerflex/datadog_checks/dell_powerflex/check.py Outdated
Comment thread .codecov.yml
@sarah-witt sarah-witt marked this pull request as ready for review May 13, 2026 18:04
@sarah-witt sarah-witt requested review from a team as code owners May 13, 2026 18:04
@sarah-witt sarah-witt changed the title Add Dell Powerflex Integration [AI-6534] Add Dell Powerflex Integration May 13, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 13, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb8bc69f7e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if self._collect_events(last_event_ts):
self.write_persistent_cache('last_event_timestamp', now)
if self.config.collect_alerts:
last_alert_ts = self.read_persistent_cache('last_alert_timestamp') or now
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Don't seed alert collection at the current time

When collect_alerts is enabled for an existing PowerFlex gateway with no cache yet, this initializes the lower-bound filter to the agent's current time before calling /rest/v1/alerts?filter=last_updated ge .... Any active alert whose last_updated is earlier than that first check is filtered out and never emitted unless it is updated later, so users can miss pre-existing incidents immediately after enabling the integration. Consider fetching active alerts on the first run or seeding from an older/empty cursor and then advancing the cache from the returned alert timestamps.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to miss preexisting alerts.

@maycmlee maycmlee added the editorial review Waiting on a more in-depth review from a docs team editor label May 13, 2026
@maycmlee
Copy link
Copy Markdown
Contributor

maycmlee commented May 13, 2026

Created DOCS-14392 for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants