Skip to content

add decibel-milliwatt canonical unit#23601

Merged
markdowney merged 5 commits into
masterfrom
mark.downey/decibel-milliwatt-unit
May 13, 2026
Merged

add decibel-milliwatt canonical unit#23601
markdowney merged 5 commits into
masterfrom
mark.downey/decibel-milliwatt-unit

Conversation

@markdowney
Copy link
Copy Markdown

What does this PR do?

Adds decibel-milliwatt to the list of canonical unit names. Third step of instructions to add a a new canonical unit

Related PRs:

Motivation

The agent wlan core check has been emitting a system.wlan.rssi metric without a unit and dBm is a missing canonical unit.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 5, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.95%. Comparing base (c0767bc) to head (512f8aa).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-prod-us1-6
Copy link
Copy Markdown

datadog-prod-us1-6 Bot commented May 5, 2026

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 158 Tests failed

test_e2e_cisco_legacy_wlc from test_e2e_core.py   View in Datadog   (Fix with Cursor)
Needed at least 1 candidates for 'snmp.device.reachable', got 0
Expected:
        MetricStub(name='snmp.device.reachable', type=0, value=1, tags=['agent_host:runnervmrc6n4', 'device_hostname:DDOGWLC', 'device_id:default:172.18.0.2', 'device_ip:172.18.0.2', 'device_namespace:default', 'device_vendor:cisco', 'snmp_device:172.18.0.2', 'snmp_host:DDOGWLC', 'snmp_profile:cisco-legacy-wlc'], hostname=None, device=None, flush_first_value=None)
Difference to closest:
        Expected tag agent_host:runnervmrc6n4
        Found agent_host:None
        Expected tag device_hostname:DDOGWLC
        Found device_hostname:None
        Expected tag device_id:default:172.18.0.2
        Found device_id:None
...
test_e2e_cisco_nexus from test_e2e_core.py   View in Datadog   (Fix with Cursor)
Needed at least 1 candidates for 'snmp.device.reachable', got 0
Expected:
        MetricStub(name='snmp.device.reachable', type=0, value=1, tags=['agent_host:runnervmrc6n4', 'device_hostname:Nexus-eu1.companyname.managed', 'device_id:default:172.18.0.2', 'device_ip:172.18.0.2', 'device_namespace:default', 'device_vendor:cisco', 'snmp_device:172.18.0.2', 'snmp_host:Nexus-eu1.companyname.managed', 'snmp_profile:cisco-nexus'], hostname=None, device=None, flush_first_value=None)
Difference to closest:
        Expected tag agent_host:runnervmrc6n4
        Found agent_host:None
        Expected tag device_hostname:Nexus-eu1.companyname.managed
        Found device_hostname:None
        Expected tag device_id:default:172.18.0.2
        Found device_id:None
...
test_e2e_core_cisco_csr from test_e2e_core.py   View in Datadog   (Fix with Cursor)
Needed at least 1 candidates for 'snmp.device.reachable', got 0
Expected:
        MetricStub(name='snmp.device.reachable', type=0, value=1, tags=['agent_host:runnervmrc6n4', 'device_id:default:172.18.0.2', 'device_ip:172.18.0.2', 'device_namespace:default', 'device_vendor:cisco', 'snmp_device:172.18.0.2', 'snmp_profile:cisco-csr1000v'], hostname=None, device=None, flush_first_value=None)
Difference to closest:
        Expected tag agent_host:runnervmrc6n4
        Found agent_host:None
        Expected tag device_id:default:172.18.0.2
        Found device_id:None
        Expected tag device_ip:172.18.0.2
        Found device_ip:None
...
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 87.50% (+0.11%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 512f8aa | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 13, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@markdowney markdowney added this pull request to the merge queue May 13, 2026
Merged via the queue into master with commit 97c187b May 13, 2026
360 of 361 checks passed
@markdowney markdowney deleted the mark.downey/decibel-milliwatt-unit branch May 13, 2026 15:31
@dd-octo-sts dd-octo-sts Bot added this to the 7.81.0 milestone May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants