Skip to content

Add New External DNS Metrics: controller.consecutive.soft.errors & controller.last_reconcile #23671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ddog-nasirthomas wants to merge 4 commits into
base: master
Choose a base branch
from
+18 −7
Open

Add New External DNS Metrics: controller.consecutive.soft.errors & controller.last_reconcile #23671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5fd5ab
Add metrics external_dns_controller_consecutive_soft_errors & externa…
ddog-nasirthomas May 11, 2026
e7ec105
Updating naming of controller.last_reconcile
ddog-nasirthomas May 11, 2026
7333ae0
Add changelog
ddog-nasirthomas May 11, 2026
2405a17
Sorting metric names
ddog-nasirthomas May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions external_dns/changelog.d/23671.added
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added metrics external_dns.controller.last_reconcile & external_dns.controller.consecutive.soft.errors
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge End the changelog fragment with a period

The root AGENTS.md changelog instructions require each entry to be a single line that ends with a period. This new fragment currently lacks the trailing period, so it violates the repository's documented changelog format for shipped Agent changes.

Useful? React with 👍 / 👎.

2 changes: 2 additions & 0 deletions external_dns/datadog_checks/external_dns/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@
'source_errors_total': 'source.errors.total',
'registry_errors_total': 'registry.errors.total',
'external_dns_controller_last_sync_timestamp_seconds': 'controller.last_sync',
'external_dns_controller_consecutive_soft_errors': 'controller.consecutive.soft.errors',
'external_dns_controller_last_reconcile_timestamp_seconds': 'controller.last_reconcile',
}
14 changes: 8 additions & 6 deletions external_dns/metadata.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric
external_dns.controller.last_sync,gauge,,second,,Timestamp of last successful sync with the DNS provider,0,external_dns,controller last sync timestamp,
external_dns.registry.endpoints.total,gauge,,resource,,Number of registry endpoints,0,external_dns,registry endpoints,
external_dns.registry.errors.total,gauge,,error,,Number of registry errors,-1,external_dns,registry errors,
external_dns.source.endpoints.total,gauge,,resource,,Number of source endpoints,0,external_dns,source endpoints,
external_dns.source.errors.total,gauge,,error,,Number of source errors,-1,external_dns,source errors,
metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric,sample_tags
external_dns.controller.consecutive.soft.errors,gauge,,error,,Number of consecutive soft errors in reconciliation loop,-1,external_dns,controller consecutive soft errors,,
external_dns.controller.last_reconcile,gauge,,second,,Timestamp of last reconcile attempt,0,external_dns,controller last reconcile timestamp,,
external_dns.controller.last_sync,gauge,,second,,Timestamp of last successful sync with the DNS provider,0,external_dns,controller last sync timestamp,,
external_dns.registry.endpoints.total,gauge,,resource,,Number of registry endpoints,0,external_dns,registry endpoints,,
external_dns.registry.errors.total,gauge,,error,,Number of registry errors,-1,external_dns,registry errors,,
external_dns.source.endpoints.total,gauge,,resource,,Number of source endpoints,0,external_dns,source endpoints,,
external_dns.source.errors.total,gauge,,error,,Number of source errors,-1,external_dns,source errors,,
8 changes: 7 additions & 1 deletion external_dns/tests/fixtures/metrics.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,10 @@ registry_errors_total 0
source_errors_total 0
# HELP external_dns_controller_last_sync_timestamp_seconds Timestamp of last successful sync with the DNS provider
# TYPE external_dns_controller_last_sync_timestamp_seconds gauge
external_dns_controller_last_sync_timestamp_seconds 1.6343090342347014e+09
external_dns_controller_last_sync_timestamp_seconds 1.6343090342347014e+09
# HELP external_dns_controller_consecutive_soft_errors Number of consecutive soft errors in reconciliation loop
# TYPE external_dns_controller_consecutive_soft_errors gauge
external_dns_controller_consecutive_soft_errors 0
# HELP external_dns_controller_last_reconcile_timestamp_seconds Timestamp of last reconcile attempt
# TYPE external_dns_controller_last_reconcile_timestamp_seconds gauge
external_dns_controller_last_reconcile_timestamp_seconds 1.715520123e+09
Loading