Aarakke/release new integrations#23696
Closed
AAraKKe wants to merge 8 commits into
Closed
Conversation
* [DOCS-13885] Note that Cisco Duo Federal is not supported * Gate Duo Federal note to US1-FED site only
* add decibel-milliwatt canonical unit * add changelog
* Add Supported OS::AIX classifier tag to AIX-bundled integrations Marks the checks bundled in the AIX datadog-agent package as supporting AIX: openmetrics, ibm_mq, ibm_ace, ibm_db2, ibm_i, ibm_was, lparstats. * Update dependency resolution * Update dependency resolution --------- Co-authored-by: dd-agent-integrations-bot[bot] <dd-agent-integrations-bot[bot]@users.noreply.github.com>
* Fix release tooling to handle Supported OS::AIX classifier tag * Rename changelog to match PR number * Ignore unknown OS platforms in get_agent_requirement_line * Use explicit exclusion set for platforms not in agent requirements * Rename PLATFORMS_NOT_IN_AGENT_REQUIREMENTS to PLATFORMS_IGNORE * Apply PLATFORMS_IGNORE filter after all platform collection paths * Skip agent requirements line when an integration only supports ignored OSes - Return `None` from `get_agent_requirement_line` when all parsed platforms are in `PLATFORMS_IGNORE` (e.g. AIX-only manifests), and raise `ManifestError` only when no supported OS was declared at all. - In `release make`, skip the requirements update when the line is `None`. - Add tests for the AIX-mixed, AIX-only, and empty-supported-OS cases on both the `tile.classifier_tags` and `supported_os` paths. --------- Co-authored-by: Juanpe Araque <juanpedro.araque@datadoghq.com>
dd-octo-sts
Bot
added
documentation
changelog/no-changelog
dev/tooling
integration/ibm_mq
integration/openmetrics
integration/ibm_was
integration/ibm_db2
release
integration/ibm_i
integration/ibm_ace
dev_package
ddev
integration/cisco_duo
integration/nifi
integration/lparstats
team/container-integrations
team/agent-integrations
team/documentation
labels
Contributor
Validation ReportAll 20 validations passed. Show details
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13c51aeffb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+200
to
+201
| else: | ||
| echo_info(f'Skipping Agent requirements update for {check}: no supported platforms to include.') |
There was a problem hiding this comment.
When an integration that already has a requirements-agent-release.txt entry is later released as AIX-only, get_agent_requirement_line() now returns None and this branch only logs a skip. Because the existing pin is never removed from the requirements file, that release would continue shipping the unsupported package to the Linux/macOS/Windows Agent even though there are no included platforms left.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Release new integrations for 7.80
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged