Skip to content

Make CI action bumps easier to validate #23890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucia-sb merged 5 commits into from
Jun 5, 2026
Merged

Make CI action bumps easier to validate #23890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a21ecf3
Run release-hash-check on its own workflow changes
lucia-sb Jun 1, 2026
2617115
Remove redundant comments
lucia-sb Jun 1, 2026
e679c1e
Add dry-run mode to skip the test-results badge commit
lucia-sb Jun 1, 2026
d55e57d
Trim dry_run input descriptions
lucia-sb Jun 1, 2026
5b87fee
chore(ci): run flaky-tests workflow on test-results-master.yml changes
lucia-sb Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/flaky-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,16 @@
name: Daily Flaky Tests (every 8 hours)

on:
pull_request:
paths:
- .github/workflows/test-results-master.yml
workflow_dispatch:
inputs:
dry_run:
description: "Skip committing the test-results badge."
required: false
default: false
type: boolean

@dkirov-dd dkirov-dd Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question
I don't see where this is exercised from the PR changes
What is the use case for the dry_run?

@lucia-sb lucia-sb Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It鈥檚 so we can trigger the workflow manually with workflow_dispatch to validate changes for Renovate PRs, without updating the badge. It's on the PR description

@dkirov-dd dkirov-dd Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, from the description I understood it was meant to be used automatically to check the Renovate PRs

@dkirov-dd dkirov-dd Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we will need to remember to do this on each Renovate PR?
If so, can we run the dry_run versions of these workflows automatically instead?

@lucia-sb lucia-sb Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the validation steps to the runbook along with the other actions that need to be checked.
My concern was that this workflow is fairly expensive to run every time there's a change, since it's only really needed when emibcn/badge-action is bumped, not when the other action is. But Renovate PRs only run once a week, so I guess it's not a big deal. I added the trigger.

schedule:
# 4 AM, 12 PM, 8 PM UTC
- cron: "0 4,12,20 * * *"
Expand Down Expand Up @@ -46,4 +55,6 @@ jobs:
pull-requests: write # Needed for test-results-master

uses: ./.github/workflows/test-results-master.yml
with:
dry_run: ${{ github.event_name == 'pull_request' || inputs.dry_run || false }}
secrets: inherit
4 changes: 3 additions & 1 deletion .github/workflows/release-hash-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
- '7.[0-9]+.x'
paths:
- .in-toto/*.link
- .github/workflows/release-hash-check.yml

jobs:
build:
Expand All @@ -29,4 +30,5 @@ jobs:
with:
files: .in-toto/*.link

- run: python .github/workflows/release-hash-check.py ${{ steps.changed-files.outputs.all_changed_files }}
- if: steps.changed-files.outputs.any_changed == 'true'
run: python .github/workflows/release-hash-check.py ${{ steps.changed-files.outputs.all_changed_files }}
7 changes: 7 additions & 0 deletions .github/workflows/test-results-master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ name: Test results for the master branch

on:
workflow_call:
inputs:
dry_run:
description: "Run the badge step but skip committing to the badges branch."
required: false
default: false
type: boolean

defaults:
run:
Expand Down Expand Up @@ -66,6 +72,7 @@ jobs:
git config --local user.email "github-actions[bot]@users.noreply.github.com"

- name: Commit if stats have changed
if: ${{ !inputs.dry_run }}
run: |-
git add "${{ env.BADGE_PATH }}"
if git commit -m "Update test results from ${{ github.sha }}"; then
Expand Down
Loading