Skip to content

[postgres] Clarify relations config requires dbname or database_autodiscovery#23989

Open
joeykelroy wants to merge 4 commits into
masterfrom
joey.kelroy/postgres-relations-doc-update
Open

[postgres] Clarify relations config requires dbname or database_autodiscovery#23989
joeykelroy wants to merge 4 commits into
masterfrom
joey.kelroy/postgres-relations-doc-update

Conversation

@joeykelroy

Copy link
Copy Markdown
Contributor

Summary

  • The relations parameter description in spec.yaml only mentioned dbname as a requirement, omitting database_autodiscovery as a valid alternative
  • Updated the description to clarify that either dbname (single database) or database_autodiscovery (all databases on the instance) must be configured when using relations

Test plan

  • Verify conf.yaml.example description for the relations parameter matches the updated spec

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jun 9, 2026

Copy link
Copy Markdown

Pipelines  Tests  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

Check PR | run / Check PR changelog   View in Datadog   GitHub Actions

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 94.06% (+6.37%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cd7b129 | Docs | Datadog PR Page | Give us feedback!

@joeykelroy joeykelroy force-pushed the joey.kelroy/postgres-relations-doc-update branch from 86a6f88 to 9f34079 Compare June 9, 2026 22:25
…iscovery

The previous description only mentioned `dbname` as a requirement when
using the `relations` parameter, omitting `database_autodiscovery` as a
valid alternative for collecting relation metrics across all databases.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@joeykelroy joeykelroy force-pushed the joey.kelroy/postgres-relations-doc-update branch from 9f34079 to 20e03b2 Compare June 9, 2026 22:32
Comment thread postgres/assets/configuration/spec.yaml Outdated
joeykelroy and others added 2 commits June 10, 2026 14:15
Co-authored-by: Eric Weaver <eweaver755@gmail.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dd-octo-sts

dd-octo-sts Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
qa-label Validate the pull request declares whether it needs QA for the next Agent release

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants