Skip to content

pulsar: add container-based config discovery support#23995

Draft
martavicentenavarro wants to merge 2 commits into
DataDog:vitkyrka/disco-configfrom
martavicentenavarro:feat/martavicentenavarro/DSCVR-485-pulsar-config-discovery
Draft

pulsar: add container-based config discovery support#23995
martavicentenavarro wants to merge 2 commits into
DataDog:vitkyrka/disco-configfrom
martavicentenavarro:feat/martavicentenavarro/DSCVR-485-pulsar-config-discovery

Conversation

@martavicentenavarro

@martavicentenavarro martavicentenavarro commented Jun 10, 2026

Copy link
Copy Markdown

What does this PR do?

Adds config discovery support to the Pulsar integration. When the Datadog Agent detects a container with the pulsar AD identifier, it automatically probes port 8080 and schedules an OpenMetrics check against http://<host>:8080/metrics — no manual conf.yaml needed.

Files changed:

  • assets/configuration/spec.yamldiscovery: block with ad_identifiers: [pulsar] and from_ports strategy on port 8080
  • datadog_checks/pulsar/config_models/discovery.py — autogenerated candidates() function
  • datadog_checks/pulsar/data/auto_conf.yaml — AD identifier registration
  • tests/conftest.py — wires get_e2e_discovery_config into dd_environment and adds discovery_config fixture
  • tests/test_e2e.py — adds test_e2e_discovery E2E test

Port choice: Port 8080 is Pulsar's standard web service port — the official Docker getting started guide exposes it explicitly (-p 8080:8080) and the broker logs confirm HTTP Service started at http://0.0.0.0:8080.

Motivation

Part of the config discovery rollout (DSCVR-485). Follows the same pattern established by the krakend integration (PR #23963).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@martavicentenavarro martavicentenavarro added the qa/skip-qa Automatically skip this PR for the next QA label Jun 10, 2026
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

PR | test / check   View in Datadog   GitHub Actions

PR | test / test (linux, ubuntu-22.04, pulsar, Pulsar (py3.13-2.9), py3.13-2.9) / Pulsar (py3.13-2.9)-py3.13-2.9   View in Datadog   GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 288029f | Docs | Datadog PR Page | Give us feedback!

@martavicentenavarro martavicentenavarro self-assigned this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant