pulsar: add container-based config discovery support#23995
Draft
martavicentenavarro wants to merge 2 commits into
Draft
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds config discovery support to the Pulsar integration. When the Datadog Agent detects a container with the
pulsarAD identifier, it automatically probes port 8080 and schedules an OpenMetrics check againsthttp://<host>:8080/metrics— no manualconf.yamlneeded.Files changed:
assets/configuration/spec.yaml—discovery:block withad_identifiers: [pulsar]andfrom_portsstrategy on port 8080datadog_checks/pulsar/config_models/discovery.py— autogeneratedcandidates()functiondatadog_checks/pulsar/data/auto_conf.yaml— AD identifier registrationtests/conftest.py— wiresget_e2e_discovery_configintodd_environmentand addsdiscovery_configfixturetests/test_e2e.py— addstest_e2e_discoveryE2E testPort choice: Port 8080 is Pulsar's standard web service port — the official Docker getting started guide exposes it explicitly (
-p 8080:8080) and the broker logs confirmHTTP Service started at http://0.0.0.0:8080.Motivation
Part of the config discovery rollout (DSCVR-485). Follows the same pattern established by the krakend integration (PR #23963).