ray: add container-based config discovery support#23997
Draft
martavicentenavarro wants to merge 1 commit into
Draft
ray: add container-based config discovery support#23997martavicentenavarro wants to merge 1 commit into
martavicentenavarro wants to merge 1 commit into
Conversation
Adds config discovery for the Ray integration (DSCVR-485), following the same pattern as krakend, n8n, and pulsar. Port 8080 is Ray's documented default --metrics-export-port for Prometheus/OpenMetrics metrics.
Contributor
|
Contributor
Validation Report
Run Passed validations (20)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds config discovery support to the Ray integration. When the Datadog Agent detects a container with the
rayAD identifier, it automatically probes port 8080 and schedules an OpenMetrics check againsthttp://<host>:8080— no manualconf.yamlneeded.Files changed:
assets/configuration/spec.yaml—discovery:block withad_identifiers: [ray]andfrom_portsstrategy on port 8080datadog_checks/ray/config_models/discovery.py— autogeneratedcandidates()functiondatadog_checks/ray/data/auto_conf.yaml— AD identifier registrationtests/conftest.py— wiresget_e2e_discovery_configintodd_environment, merges withE2E_METADATA(which carriesenv_vars), and addsdiscovery_configfixturetests/test_e2e.py— addstest_e2e_discoveryE2E testPort choice: Port 8080 is Ray's documented default
--metrics-export-portfor Prometheus/OpenMetrics metrics, as described in the official Ray metrics documentation. All nodes (head and workers) expose metrics on this port inside their containers.Motivation
DSCVR-487 as part of DSCVR-484