Skip to content

Fix legacy envoy benchmark test and add openmetrics benchmark #24080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarah-witt wants to merge 3 commits into
base: master
Choose a base branch
from
+19 −1
Open

Fix legacy envoy benchmark test and add openmetrics benchmark #24080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e73734c
Fix envoy bench test and add openmetrics benchmark
sarah-witt Jun 16, 2026
a5e64a9
setup check with dd_run_check
sarah-witt Jun 16, 2026
229d134
fix license
sarah-witt Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion envoy/tests/legacy/test_bench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def test_fixture(benchmark, fixture_path, mock_http_response):
instance = INSTANCES['main']
c = Envoy('envoy', {}, [instance])

mock_http_response(file_path=fixture_path('multiple_services'))
mock_http_response(file_path=fixture_path('legacy/multiple_services'))

# Run once to get logging of unknown metrics out of the way.
c.check(instance)
Expand Down
18 changes: 18 additions & 0 deletions envoy/tests/test_bench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# (C) Datadog, Inc. 2026-present
# All rights reserved
# Licensed under a 3-clause BSD style license (see LICENSE)

from datadog_checks.envoy import Envoy

from .common import DEFAULT_INSTANCE, get_fixture_path

OPENMETRICS_FIXTURE = get_fixture_path('./openmetrics/openmetrics.txt')


def test_openmetrics_check(benchmark, dd_run_check, mock_http_response):
mock_http_response(file_path=OPENMETRICS_FIXTURE)

c = Envoy('envoy', {}, [DEFAULT_INSTANCE])
dd_run_check(c)

benchmark(c.check, DEFAULT_INSTANCE)
Loading