Copy account config schema files from backend to colive alongside the integrations#24259
Copy account config schema files from backend to colive alongside the integrations#24259nmuesch wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdb3cf1e18
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "required": true, | ||
| "password": {} | ||
| } | ||
| ] |
There was a problem hiding this comment.
Because proofpoint_on_demand/assets/dataflows.yaml declares the granular proofpoint-on-demand-logs dataflow, this account config needs a matching dataflow_config entry (as the other granular account configs in this repo do). Without any dataflow_id binding here, the account-config consumer has no way to enable or instantiate the Proofpoint On-Demand logs flow, so users can save credentials through this schema without starting log ingestion.
Useful? React with 👍 / 👎.
| "default": true | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
Because proofpoint_tap/assets/dataflows.yaml declares the granular proofpoint-tap-logs dataflow, this account config needs a matching dataflow_config entry (as the other granular account configs in this repo do). Without any dataflow_id binding here, the account-config consumer has no way to enable or instantiate the Proofpoint TAP logs flow, so users can save credentials through this schema without starting log ingestion.
Useful? React with 👍 / 👎.
|
nathanmadams
left a comment
nathanmadams
left a comment
There was a problem hiding this comment.
Claude comments seem legit though...
evazorro
left a comment
evazorro
left a comment
There was a problem hiding this comment.
Documentation got tagged as a reviewer, but I don't think there's anything here we actually need to review. Approving to unblock you
nmuesch
added
the
assets/no-dry-run
Validation Report
Run Passed validations (20)
|
3 participants
What does this PR do?
This PR moves the account config schema definitions from the backend to live alongside the integrations for:
Motivation
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged