Parse the goal reviewer verdict from the last line of its reply#24262
Draft
AAraKKe wants to merge 1 commit into
Draft
Parse the goal reviewer verdict from the last line of its reply#24262AAraKKe wants to merge 1 commit into
AAraKKe wants to merge 1 commit into
Conversation
The reviewer often writes its reasoning as prose and then the JSON verdict at the end. parse_reviewer_output previously json.loads()'d the whole reply, which failed on any preceding prose and triggered a wasteful parse-retry turn. Now parse the last non-empty line as the verdict (falling back to the whole reply for a pure-JSON response), and instruct the reviewer to emit the verdict as a single-line JSON object on the last line.
Contributor
Validation ReportAll 21 validations passed. Show details
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Parses the goal reviewer's verdict from the last line of its reply instead of requiring the entire reply to be a bare JSON object.
The reviewer agent commonly writes its reasoning as prose and then emits the
{"valid": ..., "reason": ...}verdict at the end.parse_reviewer_outputpreviously ranjson.loads()on the whole reply, which failed whenever any prose preceded the JSON. That failure triggered an extra "reply with only JSON" parse-retry turn on nearly every check — wasted tokens and latency.Changes:
parse_reviewer_outputnow reads the last non-empty line as the verdict, falling back to the whole reply (covers a pure-JSON or pretty-printed response).Motivation
The goal reviewer was failing JSON parsing and re-running on essentially every check, because its natural output is "reasoning, then verdict". Reading just the final line matches how the model actually responds and removes the spurious retries.
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged