Skip to content

remove noop call #24292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sarah-witt wants to merge 1 commit into
base: 7.80.x
Choose a base branch
from
+6 −3
Draft

remove noop call #24292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/labels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,4 +237,4 @@ def get_label_normalizer(metric_type):
elif metric_type == 'summary':
return normalize_labels_summary
else:
return no_op
return None
7 changes: 5 additions & 2 deletions datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper/base_scraper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ def generate_sample_data(self, metric):
Yield a sample of processed data.
"""
label_normalizer = get_label_normalizer(metric.type)
populate = self.label_aggregator.populate if self.label_aggregator.configured else None

for sample in metric.samples:
value = sample.value
Expand All @@ -374,8 +375,10 @@ def generate_sample_data(self, metric):
tags = []
skip_sample = False
labels = sample.labels
self.label_aggregator.populate(labels)
label_normalizer(labels)
if populate is not None:
populate(labels)
if label_normalizer is not None:
label_normalizer(labels)

for label_name, label_value in labels.items():
sample_excluder = self.exclude_metrics_by_labels.get(label_name)
Expand Down
Loading