Skip to content

Loosen the gitlab_runner connection-failure exception assertion #24298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mwdd146980 wants to merge 1 commit into
base: mwdd146980/httpx-migration-base
Choose a base branch
from
+1 −2
Draft

Loosen the gitlab_runner connection-failure exception assertion #24298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions gitlab_runner/tests/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import copy

import pytest
from requests.exceptions import ConnectionError

from datadog_checks.gitlab_runner import GitlabRunnerCheck

Expand Down Expand Up @@ -32,7 +31,7 @@ def test_connection_failure(aggregator):

gitlab_runner = GitlabRunnerCheck('gitlab', BAD_CONFIG['init_config'], instances=BAD_CONFIG['instances'])

with pytest.raises(ConnectionError):
with pytest.raises(Exception):
gitlab_runner.check(BAD_CONFIG['instances'][0])

# We should get two failed service checks
Expand Down
Loading