prefect: add container-based config discovery support - #24483
Merged
Conversation
🎉 All green!🧪 All tests passed 🔄 Datadog auto-retried 2 jobs - 2 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 969b47e | Docs | Datadog PR Page | Give us feedback! |
vitkyrka
marked this pull request as ready for review
July 13, 2026 13:16
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 969b47e211
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jeff-morgan-dd
approved these changes
Jul 13, 2026
sarah-witt
approved these changes
Jul 13, 2026
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds container-based config discovery support to prefect.
Port selection rationale: Port 4200 is Prefect's official documented default port for the self-hosted Prefect Server API when run as a standalone container.
Endpoint field: The check's config field is
prefect_url(a full API base URL, e.g.http://host:4200/api), notopenmetrics_endpoint, sospec.yamluses the manualfrom_portsstrategy form rather than thediscovery/openmetrics_from_portstemplate.ad_identifier(prefect): The short name of the officialprefecthq/prefectDocker Hub image, with no registry/org prefix and no tag.test_e2e_discovery_all_candidatescompose service: Passedcompose_service='prefect-server'explicitly, since the fixture's compose file defines multiple services and the helper's default-service fallback would not match any of them. Of the ones running theprefecthq/prefectimage, onlyprefect-serverexposes any ports.Motivation
https://datadoghq.atlassian.net/browse/DSCVR-539
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged