flink: add container-based config discovery support - #24485
Merged
Conversation
Adds a discovery.strategies block using discovery/openmetrics_from_ports (port 9249), an auto_conf.yaml ad_identifiers entry for the flink image, E2E discovery metadata wiring, and test_e2e_discovery/ test_e2e_discovery_all_candidates tests covering both the jobmanager and taskmanager roles, which share the same container image. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
🎉 All green!🧪 All tests passed 🔄 Datadog auto-retried 1 job - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 00adb58 | Docs | Datadog PR Page | Give us feedback! |
jeff-morgan-dd
approved these changes
Jul 13, 2026
sarah-witt
approved these changes
Jul 13, 2026
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds container-based config discovery support to flink.
This only supports discovering the OpenMetrics endpoint, not the legacy Datadog HTTP Reporter.
flink-metrics-prometheusreporter.flink, the official Docker Hub image.test_e2e_discoverypassesdiscovery_min_instances=2and asserts bothjobmanager.*andtaskmanager.*core metrics to verify this.TooLongFrameException ... discardedwarning (not anerror-level match, so no test change needed for that). Separately, Flink always logs a one-off benign startup notice ("Hadoop FS is not available ...:NoClassDefFoundError") in the vanillaflinkimage, which does match the defaulterrorstability pattern.test_e2e_discovery_all_candidatesnarrows that one pattern with a negative lookbehind ((?<!NoClassDefFound)error) so only that known-benign substring is excluded, leaving real error detection intact for everything else.Motivation
https://datadoghq.atlassian.net/browse/DSCVR-538
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged