Skip to content

Remove legacy Python kubelet check - #24745

Closed
tbavelier wants to merge 2 commits into
masterfrom
remove-python-kubelet-check
Closed

Remove legacy Python kubelet check#24745
tbavelier wants to merge 2 commits into
masterfrom
remove-python-kubelet-check

Conversation

@tbavelier

@tbavelier tbavelier commented Jul 31, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Removes the legacy Python kubelet check package, its tests, and its Python-package CI/release metadata. The kubelet integration tile assets, metric metadata, service checks, README, and historical changelog remain in this repository.

The sample configuration link now points to the Agent-owned core-check configuration in DataDog/datadog-agent#54295. That companion PR also removes the kubelet_core_check_enabled fallback setting.

Motivation

The Go kubelet core check has been the default since DataDog/datadog-agent#25033. Keeping the unused Python implementation installs datadog_checks/kubelet under the Agent's embedded Python site-packages and retains a second implementation path.

This follows the established pattern used when the Datadog CSI Driver and NTP checks became core-only: runtime code and configuration belong to datadog-agent, while public integration assets remain in integrations-core.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Major version bump
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@dd-octo-sts

dd-octo-sts Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 89.49% (+1.10%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c73df3e | Docs | Datadog PR Page | Give us feedback!

@tbavelier tbavelier closed this Jul 31, 2026
@tbavelier
tbavelier deleted the remove-python-kubelet-check branch July 31, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant