Remove legacy Python kubelet check - #24745
Closed
tbavelier wants to merge 2 commits into
Closed
Conversation
Contributor
|
|
Contributor
Validation ReportAll 21 validations passed. Show details
|
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: c73df3e | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the legacy Python kubelet check package, its tests, and its Python-package CI/release metadata. The kubelet integration tile assets, metric metadata, service checks, README, and historical changelog remain in this repository.
The sample configuration link now points to the Agent-owned core-check configuration in DataDog/datadog-agent#54295. That companion PR also removes the
kubelet_core_check_enabledfallback setting.Motivation
The Go kubelet core check has been the default since DataDog/datadog-agent#25033. Keeping the unused Python implementation installs
datadog_checks/kubeletunder the Agent's embedded Python site-packages and retains a second implementation path.This follows the established pattern used when the Datadog CSI Driver and NTP checks became core-only: runtime code and configuration belong to
datadog-agent, while public integration assets remain inintegrations-core.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged