Require Twine 7 for metadata 2.5 uploads - #24853
Merged
Merged
Conversation
evalya-impact-summaryevalya impact analysis |
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 06306c0 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Validation ReportAll 21 validations passed. Show details
|
steveny91
approved these changes
Aug 13, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Raises the minimum Twine version in
datadog_checks_dev[cli]from 1.11.0 to 7.0.0.Twine 7 supports uploading distributions that use core metadata 2.5. The associated changelog fragment will be consumed by a separate
datadog_checks_dev40.0.1 release PR after this PR merges.Motivation
The
datadog_checks_dev-40.0.0workflow built a valid metadata-2.5 wheel but failed before upload because the publisher's older Twine rejected that metadata version. PR #24847 updated the GitHub publishing action to v1.14.2, which includes Twine 7.datadog_checks_devalso provides the manualddev release uploadfallback, which invokes Twine directly. Requiring Twine 7 ensures that fallback can upload the same metadata-2.5 artifacts.References:
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged