Skip to content

Require Twine 7 for metadata 2.5 uploads - #24853

Merged
nubtron merged 3 commits into
masterfrom
nubtron/release-datadog-checks-dev-40.0.1
Aug 13, 2026
Merged

Require Twine 7 for metadata 2.5 uploads#24853
nubtron merged 3 commits into
masterfrom
nubtron/release-datadog-checks-dev-40.0.1

Conversation

@nubtron

@nubtron nubtron commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Raises the minimum Twine version in datadog_checks_dev[cli] from 1.11.0 to 7.0.0.

Twine 7 supports uploading distributions that use core metadata 2.5. The associated changelog fragment will be consumed by a separate datadog_checks_dev 40.0.1 release PR after this PR merges.

Motivation

The datadog_checks_dev-40.0.0 workflow built a valid metadata-2.5 wheel but failed before upload because the publisher's older Twine rejected that metadata version. PR #24847 updated the GitHub publishing action to v1.14.2, which includes Twine 7.

datadog_checks_dev also provides the manual ddev release upload fallback, which invokes Twine directly. Requiring Twine 7 ensures that fallback can upload the same metadata-2.5 artifacts.

References:

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@nubtron nubtron added release qa/skip-qa Automatically skip this PR for the next QA dev_package labels Aug 13, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 13, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   1 (always emitted)
Diff:            empty (no diff information)

Learn more about CI impact filtering

@dd-octo-sts dd-octo-sts Bot removed the release label Aug 13, 2026
@nubtron nubtron changed the title [Release] Prepare datadog_checks_dev 40.0.1 Require Twine 7 for metadata 2.5 uploads Aug 13, 2026
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 88.86%

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 06306c0 | Docs | Datadog PR Page | Give us feedback!

@nubtron
nubtron marked this pull request as ready for review August 13, 2026 15:16
@nubtron
nubtron requested a review from a team as a code owner August 13, 2026 15:16
@dd-octo-sts

dd-octo-sts Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@nubtron
nubtron added this pull request to the merge queue Aug 13, 2026
Merged via the queue into master with commit 84ce638 Aug 13, 2026
641 of 644 checks passed
@nubtron
nubtron deleted the nubtron/release-datadog-checks-dev-40.0.1 branch August 13, 2026 15:53
@dd-octo-sts dd-octo-sts Bot added this to the 7.83.0 milestone Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev_package qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants