Map ocsf.src_endpoint.uid in DNS Activity [4003] pipelines - #24855
Open
jbfeldman-dd wants to merge 2 commits into
Open
Map ocsf.src_endpoint.uid in DNS Activity [4003] pipelines#24855jbfeldman-dd wants to merge 2 commits into
jbfeldman-dd wants to merge 2 commits into
Conversation
Populate `ocsf.src_endpoint.uid` in every DNS Activity [4003] sub pipeline in this repo: - cisco_umbrella_dns: `identities.0.id` (the Umbrella identity that issued the query). - bluecat_integrity, coredns, zeek: no client device identifier exists in the source events, so fall back to `ocsf.src_endpoint.ip`. dnsfilter already maps `agentid` to `ocsf.src_endpoint.uid` and is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
evalya-impact-summaryevalya impact analysis |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 979a137637
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
`identities` is heterogeneous — a single query can carry roaming computer, network, and user identities — so indexing element zero did not establish that the value identified a device. Use an array-processor to select the identity whose `type.type` is `roaming`, and fall back to `internalip` when a query is only attributed to a non-device identity. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Populates
ocsf.src_endpoint.uidin every DNS Activity [4003] sub pipeline in this repo.Where the source events carry a client device identifier, that field is mapped:
cisco_umbrella_dnsidentities.0.id— the Umbrella identity that issued the queryWhere no client device identifier exists in the DNS sample logs,
ocsf.src_endpoint.ipis mapped instead:bluecat_integritysourceId/serverIdidentify the BlueCat appliance and are already mapped toocsf.dst_endpoint.uidcorednszeekuidis a per-connection identifier, not a device identifierdnsfilteralready mapsagentidtoocsf.src_endpoint.uid, so it is unchanged.Expected results in the
_tests.yamlfiles were updated in alphabetical key order to match the repository'sdeepSortconvention.Motivation
ocsf.src_endpoint.uidwas unpopulated across most DNS Activity pipelines, so DNS events could not be correlated to a source device by ID. Filling it consistently — with a device ID where one exists and the source IP as a stable fallback where one does not — gives every 4003 event a source endpoint identifier.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged