Skip to content

Comment on the source PR when a backport fails - #24872

Draft
Kyle-Neale wants to merge 2 commits into
masterfrom
kyle.neale/backport-failure-comments
Draft

Comment on the source PR when a backport fails#24872
Kyle-Neale wants to merge 2 commits into
masterfrom
kyle.neale/backport-failure-comments

Conversation

@Kyle-Neale

Copy link
Copy Markdown
Contributor

What does this PR do?

When ddev release port-commit --from-pr fails to backport a merged PR to one or more target branches, it now posts a comment on that PR listing each failed base and a manual retry command.

Motivation

The old tibdex/backport automation commented on the source PR when a backport failed. After consolidating onto port-commit, a failure was only visible as a red workflow run — never on the PR the developer merged. This restores that visibility.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Restore the pre-`--from-pr` behavior of reporting backport failures on
the merged PR itself. When one or more target branches fail, port-commit
now posts a best-effort comment listing each failed base and a manual
retry hint. A comment failure is warned, never raised, so it can't mask
the backport result.
@dd-octo-sts dd-octo-sts Bot added the ddev label Aug 14, 2026
@Kyle-Neale Kyle-Neale added the qa/skip-qa Automatically skip this PR for the next QA label Aug 14, 2026
@dd-octo-sts

dd-octo-sts Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Aug 14, 2026

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   1 (always emitted)
Diff (4 files):
  ddev/changelog.d/24872.added
  ddev/src/ddev/cli/release/port_commit_workflow.py
  ddev/tests/cli/release/test_port_commit.py
  ddev/tests/helpers/github_async.py

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Aug 14, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 90.38%
Overall Coverage: 88.60% (+0.10%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 74e194d | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant