Sarah/parse labels all by sarah-witt · Pull Request #24873 · DataDog/integrations-core

sarah-witt · 2026-08-14T20:41:17Z

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

datadog-prod-us1-6 · 2026-08-14T20:42:46Z

⚠️ Warnings

🚦 73 Pipeline jobs failed

PR All | test / j045310a / Kubernetes Cluster Autoscaler

🔧 Fix in code. This looks caused by changes in this PR.
TypeError: list indices must be integers or slices, not str during test execution in tests/test_e2e.py:12

PR All | test / j062aeb0 / Milvus

🔧 Fix in code. This looks caused by changes in this PR.
TypeError: list indices must be integers or slices, not str in test_check_milvus_e2e

PR All | test / j06ca546 / SNMP

🔧 Fix in code. This looks caused by changes in this PR.
1 failed test: AssertionError: Needed at least 1 candidates for 'datadog.snmp.check_duration', got 0. Expected tag 'snmp_device:172.18.0.1', found 'snmp_device:172.18.0.2'.

View all 73 failed jobs.
📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: sarah/parse-labels-all

PR All | test / j045310a / Kubernetes Cluster Autoscaler
Commit: b69b17e631281e774c35241762d9a754748883b8
Error (code / test):
TypeError: list indices must be integers or slices, not str during test execution in tests/test_e2e.py:12
CI job: https://github.com/DataDog/integrations-core/actions/runs/31839046720/job/94891746750

PR All | test / j062aeb0 / Milvus
Commit: b69b17e631281e774c35241762d9a754748883b8
Error (code / test):
TypeError: list indices must be integers or slices, not str in test_check_milvus_e2e
CI job: https://github.com/DataDog/integrations-core/actions/runs/31839046720/job/94891753899

PR All | test / j06ca546 / SNMP
Commit: b69b17e631281e774c35241762d9a754748883b8
Error (code / test):
1 failed test: AssertionError: Needed at least 1 candidates for 'datadog.snmp.check_duration', got 0. Expected tag 'snmp_device:172.18.0.1', found 'snmp_device:172.18.0.2'.
CI job: https://github.com/DataDog/integrations-core/actions/runs/31839046720/job/94891753097

Plus 58 more failing jobs not shown here.

🧪 88 Tests failed in 2 jobs

PR All | run

test_openmetrics_e2e from test_aerospike.py

Message: list indices must be integers or slices, not str
Traceback (most recent call last):
  File &#34;/home/datadog_checks_base/datadog_checks/base/checks/base.py&#34;, line 1604, in run
    self.check(instance)
    ~~~~~~~~~~^^^^^^^^^^
  File &#34;/home/datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/base.py&#34;, line 94, in check
    scraper.scrape()
    ~~~~~~~~~~~~~~^^
  File &#34;/home/datadog_checks_base/datadog_checks/base/checks/openmetrics/v2/scraper/base_scraper.py&#34;, line 362, in scrape
    self._scrape()
...

test_check[invalid mode and invalid id] from test_arangodb.py

Needed at least 1 candidates for &#39;arangodb.connection_pool.connections.created.count&#39;, got 0
Expected:
        MetricStub(name=&#39;arangodb.connection_pool.connections.created.count&#39;, type=None, value=None, tags=None, hostname=None, device=None, flush_first_value=None)
Difference to closest:
        Expected name: arangodb.connection_pool.connections.created.count
        Found arangodb.connection_pool.connections.current

Similar submitted:
Score   Most similar
0.89    MetricStub(name=&#39;arangodb.connection_pool.connections.current&#39;, type=0, value=0.0, tags=[&#39;endpoint:http://localhost:8529/_admin/metrics/v2&#39;, &#39;pool:ClusterComm&#39;, &#39;role:SINGLE&#39;], hostname=&#39;&#39;, device=None, flush_first_value=False)
...

View all failed tests

PR All Windows | run

TestStart::test_agent_build[Latest stable release] from test_docker.py

assert [call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent-dev:sarah-go-parser-labels-782-py3&#39;], shell=False),\n call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;run&#39;, &#39;-d&#39;, &#39;--name&#39;, &#39;dd_postgres_py3.12&#39;, &#39;--network&#39;, &#39;host&#39;, &#39;-v&#39;, &#39;/proc:/host/proc&#39;, &#39;-v&#39;, &#39;C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_agent_build_Latest_stable0\\temp\\config:/etc/datadog-agent/conf.d/postgres.d&#39;, &#39;-e&#39;, &#39;DD_API_KEY=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa&#39;, &#39;-e&#39;, &#39;DD_APM_ENABLED=false&#39;, &#39;-e&#39;, &#39;DD_CMD_PORT=9000&#39;, &#39;-e&#39;, &#39;DD_EXPVAR_PORT=5000&#39;, &#39;-e&#39;, &#39;DD_HOSTNAME=runnervmm66xd&#39;, &#39;-e&#39;, &#39;DD_TELEMETRY_ENABLED=1&#39;, &#39;registry.datadoghq.com/agent-dev:sarah-go-parser-labels-782-py3&#39;], shell=False, stdout=-1, stderr=-2)] == [call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent:latest&#39;], shell=False), call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;run&#39;, &#39;-d&#39;, &#39;--name&#39;, &#39;dd_postgres_py3.12&#39;, &#39;--network&#39;, &#39;host&#39;, &#39;-v&#39;, &#39;/proc:/host/proc&#39;, &#39;-v&#39;, &#39;C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_agent_build_Latest_stable0\\temp\\config:/etc/datadog-agent/conf.d/postgres.d&#39;, &#39;-e&#39;, &#39;DD_API_KEY=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa&#39;, &#39;-e&#39;, &#39;DD_APM_ENABLED=false&#39;, &#39;-e&#39;, &#39;DD_CMD_PORT=9000&#39;, &#39;-e&#39;, &#39;DD_EXPVAR_PORT=5000&#39;, &#39;-e&#39;, &#39;DD_HOSTNAME=runnervmm66xd&#39;, &#39;-e&#39;, &#39;DD_TELEMETRY_ENABLED=1&#39;, &#39;registry.datadoghq.com/agent:latest&#39;], shell=False, stdout=-1, stderr=-2)]
  
  At index 0 diff: call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent-dev:sarah-go-parser-labels-782-py3&#39;], shell=False) != call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent:latest&#39;], shell=False)
  
  Full diff:
  - [
  -     call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent:latest&#39;], shell=False),
  ? ^^^^                                                                                   ^  ^
  &#43; [call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent-dev:sarah-go-parser-labels-782-py3&#39;], shell=False),
  ? ^                                                                                &#43;&#43;&#43;&#43; &#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;  ^ &#43; ^^^^^^^^
...

TestStart::test_agent_build[Servercore without version] from test_docker.py

assert [call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent-dev:sarah-go-parser-labels-782-py3&#39;], shell=False),\n call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;run&#39;, &#39;-d&#39;, &#39;--name&#39;, &#39;dd_postgres_py3.12&#39;, &#39;--network&#39;, &#39;host&#39;, &#39;-v&#39;, &#39;/proc:/host/proc&#39;, &#39;-v&#39;, &#39;C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_agent_build_Servercore_wi0\\temp\\config:/etc/datadog-agent/conf.d/postgres.d&#39;, &#39;-e&#39;, &#39;DD_API_KEY=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa&#39;, &#39;-e&#39;, &#39;DD_APM_ENABLED=false&#39;, &#39;-e&#39;, &#39;DD_CMD_PORT=9000&#39;, &#39;-e&#39;, &#39;DD_EXPVAR_PORT=5000&#39;, &#39;-e&#39;, &#39;DD_HOSTNAME=runnervmm66xd&#39;, &#39;-e&#39;, &#39;DD_TELEMETRY_ENABLED=1&#39;, &#39;registry.datadoghq.com/agent-dev:sarah-go-parser-labels-782-py3&#39;], shell=False, stdout=-1, stderr=-2)] == [call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent-dev:master-py3-jmx-win-servercore&#39;], shell=False), call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;run&#39;, &#39;-d&#39;, &#39;--name&#39;, &#39;dd_postgres_py3.12&#39;, &#39;--network&#39;, &#39;host&#39;, &#39;-v&#39;, &#39;/proc:/host/proc&#39;, &#39;-v&#39;, &#39;C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_agent_build_Servercore_wi0\\temp\\config:/etc/datadog-agent/conf.d/postgres.d&#39;, &#39;-e&#39;, &#39;DD_API_KEY=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa&#39;, &#39;-e&#39;, &#39;DD_APM_ENABLED=false&#39;, &#39;-e&#39;, &#39;DD_CMD_PORT=9000&#39;, &#39;-e&#39;, &#39;DD_EXPVAR_PORT=5000&#39;, &#39;-e&#39;, &#39;DD_HOSTNAME=runnervmm66xd&#39;, &#39;-e&#39;, &#39;DD_TELEMETRY_ENABLED=1&#39;, &#39;registry.datadoghq.com/agent-dev:master-py3-jmx-win-servercore&#39;], shell=False, stdout=-1, stderr=-2)]
  
  At index 0 diff: call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent-dev:sarah-go-parser-labels-782-py3&#39;], shell=False) != call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent-dev:master-py3-jmx-win-servercore&#39;], shell=False)
  
  Full diff:
  - [
  -     call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent-dev:master-py3-jmx-win-servercore&#39;], shell=False),
  ? ^^^^                                                                                     ^  -      -------------------
  &#43; [call([&#39;C:\\Windows\\system32\\docker.EXE&#39;, &#39;pull&#39;, &#39;registry.datadoghq.com/agent-dev:sarah-go-parser-labels-782-py3&#39;], shell=False),
  ? ^                                                                                     ^ &#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;   &#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;&#43;
...

View all failed tests

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🔄 Datadog auto-retried 13 jobs - 2 passed on retry

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 89.09%

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 9293661 | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-08-14T20:43:27Z

Validation Report

Validation	Description	Status
`qa-label`	Validate the pull request declares whether it needs QA for the next Agent release	❌

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)

Validation	Description	Status
`agent-reqs`	Verify check versions match the Agent requirements file	✅
`ci`	Validate CI configuration and code coverage settings	✅
`codeowners`	Validate every integration has a CODEOWNERS entry	✅
`config`	Validate default configuration files against spec.yaml	✅
`dep`	Verify dependency pins are consistent and Agent-compatible	✅
`http`	Validate integrations use the HTTP wrapper correctly	✅
`imports`	Validate check imports do not use deprecated modules	✅
`integration-style`	Validate check code style conventions	✅
`jmx-metrics`	Validate JMX metrics definition files and config	✅
`labeler`	Validate PR labeler config matches integration directories	✅
`legacy-signature`	Validate no integration uses the legacy Agent check signature	✅
`license-headers`	Validate Python files have proper license headers	✅
`licenses`	Validate third-party license attribution list	✅
`metadata`	Validate metadata.csv metric definitions	✅
`models`	Validate configuration data models match spec.yaml	✅
`openmetrics`	Validate OpenMetrics integrations disable the metric limit	✅
`package`	Validate Python package metadata and naming	✅
`readmes`	Validate README files have required sections	✅
`saved-views`	Validate saved view JSON file structure and fields	✅
`version`	Validate version consistency between package and changelog	✅

View full run

sarah-witt added 18 commits July 29, 2026 13:10

Use go bridge;

cba5a55

fix

5905304

always use go bridge

aa95b6b

don't double copy

dd87505

test with agent image

a9827cd

remove fallback

44a9822

Add stub

45d9c92

use correct image

dde315a

Always return image

fc18c96

Apply suggestion from @sarah-witt

f82acd7

Apply suggestion from @sarah-witt

9603725

fix

f2f9d0a

Merge branch '7.82.x' into sarah/go-parser-bridge-782

687b85b

fix jmx tests

c909e41

fix

bbd4de9

fix

72f7dcf

test

453fed1

use full label parsing

9293661

dd-octo-sts Bot added dev/testing dev/tooling base_package ddev labels Aug 14, 2026

Navigation Menu

Uh oh!

Sarah/parse labels all - #24873

Sarah/parse labels all#24873
sarah-witt wants to merge 18 commits into
7.82.xfrom
sarah/parse-labels-all

sarah-witt commented Aug 14, 2026

Uh oh!

datadog-prod-us1-6 Bot commented Aug 14, 2026 •

edited by datadog-official Bot

Loading

Uh oh!

dd-octo-sts Bot commented Aug 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sarah-witt commented Aug 14, 2026

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Uh oh!

datadog-prod-us1-6 Bot commented Aug 14, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

dd-octo-sts Bot commented Aug 14, 2026

Validation Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

datadog-prod-us1-6 Bot commented Aug 14, 2026 •

edited by datadog-official Bot

Loading