Skip to content

[Vercel Serverless] update to include trace and span ID remappers - #2721

Merged
shaimr-dd merged 6 commits into
masterfrom
shaimr/update-vercel-logs-pipeline
Jun 30, 2025
Merged

[Vercel Serverless] update to include trace and span ID remappers#2721
shaimr-dd merged 6 commits into
masterfrom
shaimr/update-vercel-logs-pipeline

Conversation

@shaimr-dd

@shaimr-dd shaimr-dd commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Ticket, Ticket

What does this PR do?

Updates the existing Vercel Logs OOTB Pipeline to include trace and span ID remappers!

Motivation

The team at Vercel is adding trace and span correlations with logs, so we are adding support for it!

Added steps:

  1. Trace remapper: traceId gets marked as the trace ID for the log
  2. Span remapper: spanID gets marked as the span ID for the log

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@shaimr-dd shaimr-dd self-assigned this Jun 20, 2025
@shaimr-dd
shaimr-dd requested a review from a team as a code owner June 20, 2025 15:19
shaimr-dd
shaimr-dd commented Jun 23, 2025
View reviewed changes
Comment thread vercel/assets/logs/vercel_tests.yaml
"tags" : [ "source:vercel" ]
"tags" : [ "source:vercel" ],
"traceId" : "85ea8a46-d63e-4fe3-ad03-ade7c16cd36b",
"spanId": "1012381427123789198737891237891"

@shaimr-dd shaimr-dd Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reality, Vercel sends this in hex, while the span ID is actually in decimal. Will update this test in a follow-up PR!

@clifordshelton

clifordshelton commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

/merge

@dd-devflow

dd-devflow Bot commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-06-27 15:24:09 UTC ℹ️ Start processing command /merge

2025-06-27 15:24:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).

2025-06-27 17:24:54 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

@clifordshelton

clifordshelton commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

/merge

@dd-devflow

dd-devflow Bot commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-06-27 17:26:22 UTC ℹ️ Start processing command /merge

2025-06-27 17:26:33 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 0s (p90).

2025-06-27 19:26:55 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

@shaimr-dd
shaimr-dd enabled auto-merge June 30, 2025 13:49
@shaimr-dd
shaimr-dd added this pull request to the merge queue Jun 30, 2025
Merged via the queue into master with commit 2866b3e Jun 30, 2025
29 checks passed
@shaimr-dd
shaimr-dd deleted the shaimr/update-vercel-logs-pipeline branch June 30, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thibaultkrebs thibaultkrebs thibaultkrebs approved these changes

Assignees

@shaimr-dd shaimr-dd

Labels

mergequeue-status: rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shaimr-dd @clifordshelton @thibaultkrebs