Skip to content

taint based eviction: allow lengthening eviction schedule #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-1.19-dd-v1.19.9-dd.1
Choose a base branch
from
Open

taint based eviction: allow lengthening eviction schedule #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/controller/nodelifecycle/scheduler/taint_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,8 @@ func (tc *NoExecuteTaintManager) processPodOnNode(
scheduledEviction := tc.taintEvictionQueue.GetWorkerUnsafe(podNamespacedName.String())
if scheduledEviction != nil {
startTime = scheduledEviction.CreatedAt
if startTime.Add(minTolerationTime).Before(triggerTime) {
deltaScheduleSeconds:= math.Abs(startTime.Add(minTolerationTime).Sub(scheduledEviction.FireAt).Seconds())
if deltaScheduleSeconds< 10.0 { // schedule differ by less than 10s, no need to reschedule
return
}
tc.cancelWorkWithEvent(podNamespacedName)
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/nodelifecycle/scheduler/taint_manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,13 +292,13 @@ func TestUpdatePod(t *testing.T) {
expectDelete: true,
},
{
description: "lengthening toleration shouldn't work",
description: "allow lengthening toleration",
prevPod: addToleration(testutil.NewPod("pod1", "node1"), 1, 1),
newPod: addToleration(testutil.NewPod("pod1", "node1"), 1, 100),
taintedNodes: map[string][]v1.Taint{
"node1": {createNoExecuteTaint(1)},
},
expectDelete: true,
expectDelete: false,
additionalSleep: 1500 * time.Millisecond,
},
}
Expand Down