Conversation
"cargo check" and "cargo fmt" are currently not run in CI due to a bug in the matrix configuration.
$ cargo fmt --all -- --check --all-features Unrecognized option: 'all-features'
Now that we are actually checking it in CI, CI fails since the code is not formatted.
vitkyrka
force-pushed
the
vincent.whitchurch/test
branch
from
0e114c1 to
d491dd9
Compare
blt
approved these changes
Feb 27, 2025
scottopell
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
cargo fmtcheck doesn't run in CI and a lot of the files are not formatted correctly. The PR makes the check run and does an automatic format of all files to make the check pass.Motivation
Related issues
Additional Notes
The branch protection rules need to be changed since the name of the job has changed.