Merged
Conversation
preinlein
force-pushed
the
paul.reinlein/add-procfs-process-tracking
branch
5 times, most recently
from
715cd3b to
88f4254
Compare
preinlein
commented
Mar 21, 2025
preinlein
commented
Mar 21, 2025
| @@ -238,7 +261,7 @@ impl Sampler { | |||
| // which will happen if we don't have permissions or, more | |||
Contributor
Author
There was a problem hiding this comment.
the GH UI is preventing me from commenting on the right line but the:
let uptime = uptime::poll().await?;
is preventing us from simplifying the return to simply be bool
preinlein
force-pushed
the
paul.reinlein/add-procfs-process-tracking
branch
from
5033033 to
ee9f56c
Compare
preinlein
commented
Mar 24, 2025
|
|
||
| gauge!("total_rss_bytes").set(aggr.rss as f64); | ||
| gauge!("total_pss_bytes").set(aggr.pss as f64); | ||
| gauge!("processes_found").set(processes_found as f64); |
Contributor
Author
There was a problem hiding this comment.
We decided to go with consistency rather than correctness here.
Contributor
There was a problem hiding this comment.
This lint doesn't need a change in the types, just in conversion. I think you can replace this with
Suggested change
| gauge!("processes_found").set(processes_found as f64); | |
| gauge!("processes_found").set(processes_found.into()); |
Contributor
Author
There was a problem hiding this comment.
See our previous conversation: #1288 (comment)
I'd prefer to do a pass after where we address all of these together.
goxberry
reviewed
Mar 24, 2025
scottopell
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a gauge for the number of processes processed in procfs & adds a warning log for when we failed to process processes.
Motivation
We noticed some spikes in the aggregator numbers that we can't attribute too well with our current observability.
By adding these data points, we'll be better able to understand what's happening when these spikes occur.
Related issues
N/A
Additional Notes
N/A