feat: fix devcontainer for rust analyzer#1289
Merged
Conversation
preinlein
force-pushed
the
paul.reinlein/fix-devcontainer-for-rust-analyzer
branch
from
c1f8245 to
c8f2ba7
Compare
goxberry
reviewed
Mar 20, 2025
.devcontainer/devcontainer.json
Outdated
| }, | ||
| "ghcr.io/devcontainers/features/rust:1": { | ||
| "version": "1.70", | ||
| "version": "1.77", |
Contributor
There was a problem hiding this comment.
If possible, this version should match the version in
Line 3 in b3fefa3
Contributor
Author
There was a problem hiding this comment.
✅
not sure where I grabbed 1.77 from...updated it
preinlein
force-pushed
the
paul.reinlein/fix-devcontainer-for-rust-analyzer
branch
from
c8f2ba7 to
4ef19a3
Compare
blt
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This addresses some issues with the devcontainer and working in VsCode/Cursor: the rust analyzer was running into some errors around openssl/pkg-config.
With these changes, you should be able to launch VsCode/Cursor in a devcontainer and get appropriate warnings/errors in your IDE as rust-analyzer now runs.
Motivation
I wasn't seeing errors in my IDE that should have been obvious.
Related issues
N/A
Additional Notes
N/A