Skip to content

Adds 'lading config-check' that checks whether or not a given config is valid#1396

Merged
scottopell merged 2 commits intomainfrom
sopell/add-config-check-subcommand
Jul 15, 2025
Merged

Adds 'lading config-check' that checks whether or not a given config is valid#1396
scottopell merged 2 commits intomainfrom
sopell/add-config-check-subcommand

Conversation

@scottopell
Copy link
Copy Markdown
Contributor

@scottopell scottopell commented Jun 17, 2025

What does this PR do?

Adds a new sub-command lading config-check that follows the same "config" behavior and exits 0 or 1 based on whether the config was valid or not.

Motivation

Allow a faster failure feedback loop.

Related issues

Additional Notes

Copy link
Copy Markdown
Contributor Author

scottopell commented Jun 17, 2025

@scottopell scottopell force-pushed the sopell/add-run-subcommand branch from ab0361c to beebeae Compare June 17, 2025 18:23
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch from 17712d6 to 9d8e90a Compare June 17, 2025 18:23
@scottopell scottopell force-pushed the sopell/add-run-subcommand branch from beebeae to a290872 Compare June 17, 2025 18:35
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch from 9d8e90a to 4b0ebb9 Compare June 17, 2025 18:35
@scottopell scottopell force-pushed the sopell/add-run-subcommand branch from a290872 to 189d9d9 Compare June 17, 2025 18:39
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch from 4b0ebb9 to 01cac6f Compare June 17, 2025 18:39
@scottopell scottopell force-pushed the sopell/add-run-subcommand branch from 189d9d9 to 9e9fc0f Compare June 17, 2025 22:15
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch from 01cac6f to 144a4ec Compare June 17, 2025 22:15
@scottopell scottopell changed the title Implements 'lading config-check' that accepts configuration via same defaults/env/cli options as 'run' and exits 0 or 1 based on whether the config is valid Adds 'lading config-check' that checks whether or not a given config is valid Jun 17, 2025
@scottopell scottopell marked this pull request as ready for review June 17, 2025 22:19
@scottopell scottopell requested a review from a team as a code owner June 17, 2025 22:19
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch 2 times, most recently from 6b50689 to 7ee5588 Compare June 18, 2025 15:25
@scottopell scottopell marked this pull request as draft June 18, 2025 15:46
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch from 7ee5588 to b496152 Compare July 3, 2025 19:54
@scottopell scottopell force-pushed the sopell/add-run-subcommand branch from a858767 to 68203bd Compare July 3, 2025 19:54
@scottopell scottopell marked this pull request as ready for review July 15, 2025 17:53
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch from b496152 to 1546a52 Compare July 15, 2025 18:00
@scottopell scottopell force-pushed the sopell/add-run-subcommand branch 3 times, most recently from 6717a4c to 9c87dcf Compare July 15, 2025 18:11
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch from 1546a52 to d91a955 Compare July 15, 2025 18:11
@scottopell scottopell changed the base branch from sopell/add-run-subcommand to graphite-base/1396 July 15, 2025 18:23
…defaults/env/cli options as 'run' and exits 0 or 1 based on whether the config is valid
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch from d91a955 to 9727b1e Compare July 15, 2025 18:23
@scottopell scottopell force-pushed the graphite-base/1396 branch from 9c87dcf to 79a32d3 Compare July 15, 2025 18:23
@graphite-app graphite-app bot changed the base branch from graphite-base/1396 to main July 15, 2025 18:24
@scottopell scottopell force-pushed the sopell/add-config-check-subcommand branch from 9727b1e to 1ddff18 Compare July 15, 2025 18:24
@scottopell scottopell merged commit 1d1bfbf into main Jul 15, 2025
22 checks passed
Copy link
Copy Markdown
Contributor Author

Merge activity

@scottopell scottopell deleted the sopell/add-config-check-subcommand branch July 15, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants