-
Notifications
You must be signed in to change notification settings - Fork 14
Adds a 'ci/validate-linux' command to use a docker container to run ci/validate in linux env #1397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| FROM rust:1.85-bookworm | ||
|
|
||
| # Install protobuf compiler (required by Cross.toml), shellcheck (for ci/validate), and libfuse (for fuser crate) | ||
| RUN apt-get update && apt-get install -y \ | ||
| protobuf-compiler \ | ||
| shellcheck \ | ||
| libfuse3-dev \ | ||
| pkg-config \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Install nextest for testing | ||
| RUN curl -LsSf https://get.nexte.st/latest/linux-musl | tar zxf - -C ${CARGO_HOME:-~/.cargo}/bin | ||
|
|
||
| WORKDIR /workspace | ||
|
|
||
| # Copy over the source | ||
| COPY . . | ||
|
|
||
| # Run validation | ||
| CMD ["bash", "-c", "ci/validate"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #!/usr/bin/env bash | ||
| set -o errexit | ||
| set -o nounset | ||
| set -o pipefail | ||
|
|
||
| # Build the validation Docker image | ||
| echo "Building Linux validation environment..." | ||
| docker build -f ./ci/Dockerfile.validate -t lading-validate . | ||
|
|
||
| # Run validation in the container | ||
| echo "Running validation in Linux container..." | ||
| docker run --rm -v "$(pwd):/workspace" lading-validate | ||
|
|
||
| echo "Linux validation passed!" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ Code Quality Violation
package libfuse3-dev should have version pinned (...read more)
When using
apt-get install, pin the version to avoid unwanted upgrades and undefined behavior.