Add DogStatsD-over-HTTP protobuf payload (AGTMETRICS-487)#1835
Draft
carlosroman wants to merge 1 commit intomainfrom
Draft
Add DogStatsD-over-HTTP protobuf payload (AGTMETRICS-487)#1835carlosroman wants to merge 1 commit intomainfrom
carlosroman wants to merge 1 commit intomainfrom
Conversation
Introduces `DogStatsDHttp`, a new `lading_payload` serializer that encodes DogStatsD Count and Gauge metrics into the binary protobuf format expected by the Datadog Agent's DogStatsD-over-HTTP endpoint. Metric names and tag strings are stored in varint-length-prefixed byte dictionaries with delta encoding for indices, mirroring `dogstatsdhttp/payload.proto`. Adds a CI fingerprint config that exercises the payload through lading's existing `http` generator targeting the Agent at `http://127.0.0.1:8125` with `Content-Type: application/x-protobuf`.
Comment on lines
+237
to
+240
| u16::from(config.metric_weights.timer), | ||
| u16::from(config.metric_weights.distribution), | ||
| u16::from(config.metric_weights.set), | ||
| u16::from(config.metric_weights.histogram), |
Contributor
There was a problem hiding this comment.
Since they aren't supported, we might as well just stop them being generated..
Suggested change
| u16::from(config.metric_weights.timer), | |
| u16::from(config.metric_weights.distribution), | |
| u16::from(config.metric_weights.set), | |
| u16::from(config.metric_weights.histogram), | |
| 0, | |
| 0, | |
| 0, | |
| 0, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
DogStatsDHttp, a newlading_payloadserializer that encodes DogStatsD Count and Gauge metrics into the binary protobuf format expected by the Datadog Agent's DogStatsD-over-HTTP endpoint. Metric names and tag strings are stored in varint-length-prefixed byte dictionaries with delta encoding for indices, mirroringdogstatsdhttp/payload.proto.Adds a CI fingerprint config that exercises the payload through lading's existing
httpgenerator targeting the Agent athttp://127.0.0.1:8125withContent-Type: application/x-protobuf.What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Related issues
A list of issues either fixed, containing architectural discussions, otherwise relevant
for this Pull Request.
Additional Notes
Anything else we should know when reviewing?